Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W-15110724 - 250__fields-not-updated-ge-batch-process #7232

Merged

Conversation

enzigma-pratishtha-upadhyay
Copy link
Collaborator

@enzigma-pratishtha-upadhyay enzigma-pratishtha-upadhyay commented Mar 29, 2024

Critical Changes

GUS W-15110724

Updated

  1. GiftEntryProcessorQueue class : Added the BDI_DataImport_BATCH on queue to update the NPSP Data Import batch record fields.
  2. GiftBatchForQueueable class : Passed the list of data import record ids (lstDataImportIds) to call the processDataImportRecords method of BDI_DataImport_API with second parameter as List.

Changes

Issues Closed

Community Ideas Delivered

Features Intended for Future Release

Features for Elevate Customers

New Metadata

Deleted Metadata

Executing the BDI_DataImport_BATCH batch on GiftEntryProcessorQueue to update  the NPSP Data Import batch record fields.
@enzigma-pratishtha-upadhyay enzigma-pratishtha-upadhyay added the WIP Work in Progress label Mar 29, 2024
@enzigma-pratishtha-upadhyay enzigma-pratishtha-upadhyay changed the title Commit -- BDI_DataImport_BATCH is queued on GE Processor Queue feature/250__fields-not-updated-ge-batch-process Apr 2, 2024
@enzigma-pratishtha-upadhyay enzigma-pratishtha-upadhyay changed the title feature/250__fields-not-updated-ge-batch-process W-15110724 - 250__fields-not-updated-ge-batch-process Apr 2, 2024
Removed BDI_DataImport_BATCH  batch call from GiftEntryProcessorQueue and added overloaded processChunk method.
Copy link
Contributor

@daniel-fuller daniel-fuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@enzigma-pratishtha-upadhyay In the Feature Test and 2gp Feature Test autobuilds there are failing apex tests that need to be fixed in order to ensure that we haven't created a regression here with this change. Please fix the failing tests in those builds and I will re-review. Thanks.

Base automatically changed from feature/250 to main April 16, 2024 17:17
@npsp-reedestockton npsp-reedestockton changed the base branch from main to feature/252 April 16, 2024 17:19
@daniel-fuller
Copy link
Contributor

I've completed QA on this successfully and the fix is working

Copy link
Contributor

@lparrott lparrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@daniel-fuller daniel-fuller merged commit d6c12e3 into feature/252 May 14, 2024
7 of 11 checks passed
@daniel-fuller daniel-fuller deleted the feature/250__fields-not-updated-ge-batch-process branch May 14, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants