Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating our refund logic to work with negative payments and no Debit Type #7162

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Updating our refund logic to work with negative payments and no Debit Type #7162

merged 1 commit into from
Dec 7, 2022

Conversation

lparrott
Copy link
Contributor

@lparrott lparrott commented Dec 6, 2022

  • Updating our refund logic to work with negative payments that are not created through the UI
  • This change should fix the test failures in Accounting Subledger

Critical Changes

Changes

Issues Closed

Community Ideas Delivered

Features Intended for Future Release

Features for Elevate Customers

New Metadata

Deleted Metadata

npsp-reedestockton
npsp-reedestockton approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@npsp-reedestockton npsp-reedestockton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid!

@lparrott lparrott merged commit f049983 into main Dec 7, 2022
@lparrott lparrott deleted the feature/fixSubledgerRefundTests branch December 7, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewyu-salesforce andrewyu-salesforce andrewyu-salesforce approved these changes

@npsp-reedestockton npsp-reedestockton npsp-reedestockton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lparrott @npsp-reedestockton @andrewyu-salesforce