Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signature doesn't trigger with autopairs #909

Closed
2 tasks done
ohogb opened this issue Jan 5, 2025 · 0 comments · Fixed by #935
Closed
2 tasks done

Signature doesn't trigger with autopairs #909

ohogb opened this issue Jan 5, 2025 · 0 comments · Fixed by #935
Labels
bug Something isn't working

Comments

@ohogb
Copy link
Contributor

ohogb commented Jan 5, 2025

Make sure you have done the following

  • Updated to the latest version of blink.cmp
  • Searched for existing issues and documentation (try <C-k> on https://cmp.saghen.dev!)

Bug Description

Without an autopairs plugin:

funcname|
-- press (
funcname(|
-- triggers signature

With an autopairs plugin (mini.pairs or nvim-autopairs):

funcname|
-- press (
funcname(|)
-- no signature

Signature triggers normally after pressing , when inside the pairs, or going to normal mode and back to insert mode while inside the pairs.

Repro with mini.pairs:
repro.lua.txt

Relevant configuration

No response

neovim version

NVIM v0.11.0-dev-1481+g570a8da01b

blink.cmp version

main
@ohogb ohogb added the bug Something isn't working label Jan 5, 2025
@mehalter mehalter mentioned this issue Jan 7, 2025
Draft
ohogb added a commit to ohogb/blink.cmp that referenced this issue Jan 7, 2025
@ohogb
fix(signature): use char_under_cursor in on_char_added handler
b894cf8 
`char` from the `on_char_added` handler, which was used before, doesn't
represent the character under the cursor in some situations, such as
when using an autopairs plugin.

Fixes Saghen#909
@ohogb ohogb mentioned this issue Jan 7, 2025
Merged
@Saghen Saghen closed this as completed in 275d407 Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(signature): use char_under_cursor in on_char_added handler ohogb/blink.cmp
1 participant
@ohogb