issue #254 - fixed some glitches in generators-fast transform and uni…

…t tests
Sage · Mar 7, 2015 · 256f876 · 256f876
1 parent 805419e
commit 256f876
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/lib/generators-fast/flows.js b/lib/generators-fast/flows.js
@@ -109,7 +109,7 @@
 		function() {
 			var funnel = exports.funnel(max);
 			this.collect = function*(_, count, trim) {
-				return (yield galaxy.invoke((function(callback) {
+				return (yield galaxy.invoke(function(callback) {
 					if (typeof(callback) != "function") throw new Error("invalid call to collect: no callback");
 					var results = trim ? [] : new Array(fns.length);
 					count = count < 0 ? fns.length : Math.min(count, fns.length);
@@ -125,7 +125,7 @@
 							} , fns[i]);
 						})(i);
 					}
-				}, "call", [this, _], 1));
+				}, "call", [this , _], 1));
 			};
 			this.collectOne = function*(_) {
 				var result = (yield this.collect(_, 1, true));
@@ -334,7 +334,7 @@
 	/// * `flows.sleep(_, millis)`  
 	///   Sleeps `millis` ms.  
 	exports.sleep = function*(_, millis) {
-		return (yield galaxy.invoke(null, setTimeout, [_, millis], 0));
+		return (yield galaxy.invoke(null, setTimeout, [_ , millis], 0));
 	};
 
 	exports.eventHandler = function(fn) {

diff --git a/lib/generators-fast/transform.js b/lib/generators-fast/transform.js
@@ -169,6 +169,7 @@ function transform(source, options) {
 				skipTo(expr.range[0]);
 				buffer += '(yield galaxy.invoke(';
 				if (expr.type === 'MemberExpression') {
+					skipTo(expr.object.range[0]);
 					if (!expr.computed) {
 						// Method call: foo.bar(_)
 						walk(expr.object);
@@ -191,9 +192,9 @@ function transform(source, options) {
 				}
 				// Render arguments
 				buffer += ', [';
-				skipTo(args[0].range[0]);
 				for (var ii = 0; ii < args.length; ++ii) {
-					catchup(args[ii].range[0]);
+					skipTo(args[ii].range[0]);
+					if (ii > 0) buffer += ', ';
 					if (ii !== idx) {
 						walk(args[ii]);
 						catchup(args[ii].range[1]);
@@ -271,6 +272,7 @@ function transform(source, options) {
 				var isPromise = args[idx].operator === "void";
 				catchup(this.range[0]);
 				buffer += 'galaxy.' + (isPromise ? 'promise' : 'spin') + '.call(this, ';
+				skipTo(expr.range[0]);
 				walk(expr);
 				catchup(expr.range[1]);
 				if (isPromise) buffer += ', [';

diff --git a/test/common/flows-test._js b/test/common/flows-test._js
@@ -336,7 +336,7 @@ asyncTest("collectAll", 4, function(_) {
 		return function(_) {
 			count++;
 			peak = Math.max(count, peak);
-			setTimeout(_, 10);
+			setTimeout(~_, 10);
 			total = delay(_, i) + total;
 			count--;
 			return 2 * i;
@@ -359,7 +359,7 @@ asyncTest("collectOne", 4, function(_) {
 		return function(_) {
 			count++;
 			peak = Math.max(count, peak);
-			setTimeout(_, 10);
+			setTimeout(~_, 10);
 			total = delay(_, i) + total;
 			count--;
 			return 2 * i;
@@ -382,7 +382,7 @@ asyncTest("collectAll with limit", 1, function(_) {
 		return function(_) {
 			count++;
 			peak = Math.max(count, peak);
-			setTimeout(_, 10);
+			setTimeout(~_, 10);
 			total = delay(_, i) + total;
 			count--;
 			return 2 * i;