-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(loader-bar): create loader-bar - FE-4119 #4306
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9bc55e8:
|
e0415ae
to
caf2700
Compare
caf2700
to
5038070
Compare
5038070
to
11a8e79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rdzielakpgs just the missing ;
to add in, happy to approve once it is 😄
11a8e79
to
74600e1
Compare
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
730254d
to
21192ca
Compare
After speaking with @DlgSHi and reviewing margins applied with no provided guidance, it is best if we keep small as it is at 6px, but update medium and large to use right margin 8px, so that it follows our formula and the fact pulse effect on loader limits squares coming close together. |
2740cad
to
a7aa610
Compare
a7aa610
to
4b9efcb
Compare
b911f39
to
a5d5f7c
Compare
🎉 This PR is included in version 84.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Proposed behaviour
A new animated version has been added to the Loaders: the loader bar (May 19). This new variant is used in File inputs component (new component coming soon).
User Story
As a user uploading a file to the system (new component to come soon)
I want to have a visual indicator
so that I know that uploading the file is still in progress.
Acceptance Criteria
As a developer using Carbon I should be able to add a Loader bar into my product that matches the DS spec,
It respects the theme selected,
all variations and states described on the DS spec are available.
It aligns with the other Carbon components - margins, test coverage, ...
We refer to Loaders v 0.2.0. This version should be implemented.
Storybook MDX updated with a compatibility table showing which version of the Design System is implemented
Current behaviour
There is no loader-bar component available
Checklist
d.ts
file added or updated if requiredAdditional context
Testing instructions