Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(loader-bar): create loader-bar - FE-4119 #4306

Merged
merged 2 commits into from
Sep 13, 2021

Conversation

rdzielakpgs
Copy link
Contributor

@rdzielakpgs rdzielakpgs commented Aug 13, 2021

Proposed behaviour

A new animated version has been added to the Loaders: the loader bar (May 19). This new variant is used in File inputs component (new component coming soon).

User Story
As a user uploading a file to the system (new component to come soon)
I want to have a visual indicator
so that I know that uploading the file is still in progress.

Acceptance Criteria

As a developer using Carbon I should be able to add a Loader bar into my product that matches the DS spec,
It respects the theme selected,
all variations and states described on the DS spec are available.
It aligns with the other Carbon components - margins, test coverage, ...
We refer to Loaders v 0.2.0. This version should be implemented.
Storybook MDX updated with a compatibility table showing which version of the Design System is implemented

Current behaviour

There is no loader-bar component available

Checklist

  • Commits follow our style guide
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Cypress automation tests added or updated if required
  • Storybook added or updated if required
  • Typescript d.ts file added or updated if required
  • Carbon implementation and Design System documentation are congruent

Additional context

image

Testing instructions

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 13, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9bc55e8:

Sandbox Source
carbon-quickstart Configuration

src/components/loader/loader-bar.component.js Outdated Show resolved Hide resolved
src/components/loader/loader-bar.component.js Outdated Show resolved Hide resolved
src/components/loader/loader-bar.spec.js Outdated Show resolved Hide resolved
src/components/loader/loader-bar.style.js Outdated Show resolved Hide resolved
src/components/loader/loader.stories.mdx Outdated Show resolved Hide resolved
src/components/loader/loader.stories.mdx Outdated Show resolved Hide resolved
samtjo
samtjo previously approved these changes Aug 24, 2021
Copy link
Contributor

@edleeks87 edleeks87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rdzielakpgs just the missing ; to add in, happy to approve once it is 😄

src/components/loader/loader-bar.style.js Outdated Show resolved Hide resolved
edleeks87
edleeks87 previously approved these changes Aug 27, 2021
samtjo
samtjo previously approved these changes Aug 31, 2021
@cypress
Copy link

cypress bot commented Aug 31, 2021



Test summary

1265 0 3 0Flakiness 0


Run details

Project carbon
Status Passed
Commit 9bc55e8
Started Sep 13, 2021 8:31 AM
Ended Sep 13, 2021 8:35 AM
Duration 04:51 💡
OS Linux Debian - 10.9
Browser Chrome 91

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@DlgSHi DlgSHi dismissed stale reviews from samtjo and edleeks87 via f2f6fb5 September 6, 2021 11:17
@rdzielakpgs rdzielakpgs force-pushed the loader-bar branch 3 times, most recently from 730254d to 21192ca Compare September 6, 2021 11:55
@harpalsingh
Copy link
Member

After speaking with @DlgSHi and reviewing margins applied with no provided guidance, it is best if we keep small as it is at 6px, but update medium and large to use right margin 8px, so that it follows our formula and the fact pulse effect on loader limits squares coming close together.

src/components/loader-bar/loader-bar.component.js Outdated Show resolved Hide resolved
src/components/loader-bar/loader-bar.stories.mdx Outdated Show resolved Hide resolved
src/components/loader-bar/loader-bar.stories.mdx Outdated Show resolved Hide resolved
src/components/loader/loader-square.style.js Outdated Show resolved Hide resolved
src/components/loader/loader-square.style.js Outdated Show resolved Hide resolved
src/components/loader/loader-square.style.js Outdated Show resolved Hide resolved
cypress/fixtures/commonComponents/loader.json Show resolved Hide resolved
@DlgSHi DlgSHi marked this pull request as ready for review September 13, 2021 06:30
@DlgSHi DlgSHi requested review from a team as code owners September 13, 2021 06:30
@DlgSHi DlgSHi merged commit 15d0893 into Sage:master Sep 13, 2021
@DlgSHi DlgSHi deleted the loader-bar branch September 13, 2021 08:53
@carbonci
Copy link
Collaborator

🎉 This PR is included in version 84.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

8 participants