Bump dependencies, take 2 #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 15e1ea7.
- add "prop-types" as a dependency - upgrade SVGR plugins (must now use @svgr/plugin-jsx) - simplify vite.config.ts files
nickgros
commented
Jul 11, 2023
| @@ -78,6 +76,7 @@ | |||
| "mui-one-time-password-input": "1.1.0", | |||
| "plotly.js-basic-dist": "^2.24.3", | |||
| "pluralize": "^8.0.0", | |||
| "prop-types": "^15.8.1", | |||
There was a problem hiding this comment.
For some reason, tsup isn't bundling/properly writing a dynamic import for the prop-types dependency, which is imported via react-switch (but also many other dependencies?)
This issue resolves if we include it in our dependencies.
nickgros
commented
Jul 11, 2023
| @@ -95,7 +94,7 @@ | |||
| "react-router-dom": "^5.3.4", | |||
| "react-select": "^5.7.3", | |||
| "react-sizeme": "^3.0.2", | |||
| "react-test-renderer": "^18.2.0", | |||
| "react-switch": "^7.0.0", | |||
There was a problem hiding this comment.
move from devDependencies
nickgros
commented
Jul 11, 2023
| @@ -95,7 +94,7 @@ | |||
| "react-router-dom": "^5.3.4", | |||
| "react-select": "^5.7.3", | |||
| "react-sizeme": "^3.0.2", | |||
| "react-test-renderer": "^18.2.0", | |||
There was a problem hiding this comment.
remove from dependencies (it's already in devDependencies)
nickgros
commented
Jul 11, 2023
| @@ -45,6 +45,7 @@ const esBuildOptions = { | |||
| loadPaths: ['../../node_modules', 'node_modules'], | |||
| }), | |||
| svgrPlugin({ | |||
| plugins: ['@svgr/plugin-jsx'], | |||
There was a problem hiding this comment.
Upgraded svgr plugins use new versions of svgr which require specifying the plugins we use. We just use the jsx plugin.
jay-hodgson
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-include the changes in #354 plus