This repository has been archived by the owner on Jul 17, 2023. It is now read-only.
PORTALS-2382: tag user or team in markdown editor #1869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Currently when tagging teams or non existent user handles, MarkdownSynapse does not render it. Screen.Recording.2022-10-28.at.1.55.15.PM.mov |
jay-hodgson
reviewed
Oct 28, 2022
| <Modal.Title>Find User or Team</Modal.Title> | ||
| </Modal.Header> | ||
| <Modal.Body> | ||
| <UserSearchBoxV2 |
There was a problem hiding this comment.
Maybe set the TYPE_FILTER to USERS_ONLY until we work out the Team renderer. My guess is that the markdown processor is working correctly, but we are not filling in the team badge in SRC
jay-hodgson
approved these changes
Oct 28, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.