BREAKING CHANGE: add support to log tenantId #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanjain14
reviewed
Dec 8, 2022
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "logger-safe-security", | |||
| "version": "1.2.1", | |||
| "version": "1.2.2", | |||
There was a problem hiding this comment.
Revert this change. We have auto-release configured.
amanjain14
reviewed
Dec 8, 2022
src/index.ts
Outdated
| info.tenantId = valueFromMethod<string>("tenantId"); | ||
| } | ||
| } catch (error) { | ||
| console.error( |
amanjain14
suggested changes
Dec 8, 2022
src/index.ts
Outdated
| /* A custom format that is used to include tenantId. */ | ||
| const formatTenantId = (parameters: ParameterConfig | undefined) => { | ||
| return winston.format(info => { | ||
| info.tenantId = ""; |
There was a problem hiding this comment.
Remove this as well. If we get tenantId from the context then use it, else make no changes.
| @@ -18,16 +27,44 @@ const formatError = winston.format(info => { | |||
| return info; | |||
| }); | |||
|
|
|||
| /* A custom format that is used to include tenantId. */ | |||
| const formatTenantId = (parameters: ParameterConfig | undefined) => { | |||
| return winston.format(info => { | |||
There was a problem hiding this comment.
Can we remove the dependency on the tenantId and make this generic?
From the parameters config, get the keys, check if the key is present in the store, if yes, add it to info else skip.
There was a problem hiding this comment.
Please update the PR title with breaking changes.
Substancia
changed the title
Substancia
changed the title
|
To test this:- New |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 13, 2022
# [2.0.0](v1.2.1...v2.0.0) (2022-12-13) ### Features * add support to log additional attributes by default ([#17](#17)) ([1d022c7](1d022c7)) ### BREAKING CHANGES * add arbitrary parameters to be part of every log line by default
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes handling of missing contexts.
Evidences:-
MT with context: https://app.flonnect.com/view/video/jibin.m/63919070f31aaa756ef77d3d
MT without context: https://app.flonnect.com/view/video/jibin.m/63919100f31aaa756ef77d5f
ST: https://app.flonnect.com/view/video/jibin.m/6391944cf31aaa756ef77df4