Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make schema parameter of Rows optional #15

Closed
Gerhardsa0 opened this issue Dec 23, 2022 · 2 comments · Fixed by #134
Closed

Make schema parameter of Rows optional #15

Gerhardsa0 opened this issue Dec 23, 2022 · 2 comments · Fixed by #134
Assignees
@lars-reimann
Labels
enhancement 💡 New feature or request released Included in a release

Comments

@Gerhardsa0
Copy link
Contributor

Gerhardsa0 commented Dec 23, 2022 •
edited by GideonKoenig
Loading

Is your feature request related to a problem? Please describe

We always need to call the Row constructor with a TableSchema object, this can be annoying and could lead to mistakes. It would be great if we would just have one Parameter Iterable.

Desired solution

Make the TableSchema Parameter optional and create the TableSchema implicit.

Possible alternatives (optional)

We also have done that in the table class.

Screenshots (optional)

def __init__(self, data: typing.Iterable, schema: TableSchema):
@Gerhardsa0 Gerhardsa0 added the enhancement 💡 New feature or request label Dec 23, 2022
@lars-reimann
Copy link
Member

lars-reimann commented Dec 23, 2022 •
edited
Loading

Seems like a good idea. We can change the type of the schema parameter to Optional[TableSchema] and give it a default value of None. If a TableSchema is passed, we use that and if None is passed, we infer the schema.

We could do the same for the type of columns. It should also be done like this for a Table, so we don't infer the schema again if we already know it.

@Gerhardsa0 Gerhardsa0 reopened this Jan 13, 2023
@lars-reimann lars-reimann transferred this issue from Safe-DS/DSL Mar 4, 2023
@lars-reimann lars-reimann self-assigned this Mar 27, 2023
@lars-reimann lars-reimann changed the title TableSchema als Parameter in Rows Make schema parameter of Rows optional Mar 27, 2023
@lars-reimann lars-reimann linked a pull request Mar 31, 2023 that will close this issue
feat: infer schema of row if not passed explicitly #134
Merged
@lars-reimann lars-reimann mentioned this issue Mar 31, 2023
Merged
lars-reimann added a commit that referenced this issue Mar 31, 2023
@lars-reimann @github-actions
feat: infer schema of row if not passed explicitly (#134)
c5869bb 
Closes #15.

### Summary of Changes

The `schema` parameter of the `Row` initializer is now optional. If it's
not passed explicitly, it gets inferred from the data. The column names
are set to `column_0`, `column_1`, etc.

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
lars-reimann pushed a commit that referenced this issue Mar 31, 2023
@semantic-release-bot
chore(release): 0.8.0 [skip ci]
2acbc6a 
## [0.8.0](v0.7.0...v0.8.0) (2023-03-31)

### Features

* create empty `Table` without schema ([#128](#128)) ([ddd3f59](ddd3f59)), closes [#127](#127)
* improve `ColumnType`s ([#132](#132)) ([1786a87](1786a87)), closes [#113](#113)
* infer schema of row if not passed explicitly ([#134](#134)) ([c5869bb](c5869bb)), closes [#15](#15)
* new method `is_fitted` to check whether a model is fitted ([#130](#130)) ([8e1c3ea](8e1c3ea))
* new method `is_fitted` to check whether a transformer is fitted ([#131](#131)) ([e20954f](e20954f))
* rename `drop_XY` methods of `Table` to `remove_XY` ([#122](#122)) ([98d76a4](98d76a4))
* rename `fit_transform` to `fit_and_transform` ([#119](#119)) ([76a7112](76a7112)), closes [#112](#112)
* rename `shuffle` to `shuffle_rows` ([#125](#125)) ([ea21928](ea21928))
* rename `slice` to `slice_rows` ([#126](#126)) ([20d21c2](20d21c2))
* rename `TableSchema` to `Schema` ([#133](#133)) ([1419d25](1419d25))
@lars-reimann
Copy link
Member

🎉 This issue has been resolved in version 0.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lars-reimann lars-reimann

Labels
enhancement 💡 New feature or request released Included in a release
Projects
Library
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: infer schema of row if not passed explicitly Safe-DS/Library
3 participants
@lars-reimann @dorianheidorn @Gerhardsa0