Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create empty Table without schema #128

Merged
merged 3 commits into from
Mar 30, 2023

Conversation

lars-reimann
Copy link
Member

Summary of Changes

We no longer raise an exception when a user creates an empty Table without specifying a schema. Table([]) is now allows.

add_row and add_rows must still be adjusted (#127) to allow adding rows to such an empty Table.

@lars-reimann lars-reimann requested a review from a team as a code owner March 30, 2023 16:29
@lars-reimann lars-reimann linked an issue Mar 30, 2023 that may be closed by this pull request
@lars-reimann
Copy link
Member Author

lars-reimann commented Mar 30, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 2 0 0 0.86s
✅ PYTHON flake8 2 0 0.51s
✅ PYTHON isort 2 0 0 0.25s
✅ PYTHON mypy 2 0 2.25s
✅ PYTHON pylint 2 0 3.2s
✅ REPOSITORY git_diff yes no 0.02s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #128 (f850d34) into main (20d21c2) will increase coverage by 0.06%.
The diff coverage is 100.00%.

❗ Current head f850d34 differs from pull request most recent head d0abb62. Consider uploading reports for the commit d0abb62 to get more accurate results

@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
+ Coverage   93.08%   93.15%   +0.06%     
==========================================
  Files          36       36              
  Lines        1258     1256       -2     
==========================================
- Hits         1171     1170       -1     
+ Misses         87       86       -1     
Impacted Files Coverage Δ
src/safeds/data/tabular/containers/_table.py 91.40% <100.00%> (+0.26%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lars-reimann lars-reimann merged commit ddd3f59 into main Mar 30, 2023
@lars-reimann lars-reimann deleted the 75-allow-creating-an-empty-table-without-schema branch March 30, 2023 16:36
lars-reimann pushed a commit that referenced this pull request Mar 31, 2023
## [0.8.0](v0.7.0...v0.8.0) (2023-03-31)

### Features

* create empty `Table` without schema ([#128](#128)) ([ddd3f59](ddd3f59)), closes [#127](#127)
* improve `ColumnType`s ([#132](#132)) ([1786a87](1786a87)), closes [#113](#113)
* infer schema of row if not passed explicitly ([#134](#134)) ([c5869bb](c5869bb)), closes [#15](#15)
* new method `is_fitted` to check whether a model is fitted ([#130](#130)) ([8e1c3ea](8e1c3ea))
* new method `is_fitted` to check whether a transformer is fitted ([#131](#131)) ([e20954f](e20954f))
* rename `drop_XY` methods of `Table` to `remove_XY` ([#122](#122)) ([98d76a4](98d76a4))
* rename `fit_transform` to `fit_and_transform` ([#119](#119)) ([76a7112](76a7112)), closes [#112](#112)
* rename `shuffle` to `shuffle_rows` ([#125](#125)) ([ea21928](ea21928))
* rename `slice` to `slice_rows` ([#126](#126)) ([20d21c2](20d21c2))
* rename `TableSchema` to `Schema` ([#133](#133)) ([1419d25](1419d25))
@lars-reimann
Copy link
Member Author

🎉 This PR is included in version 0.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow creating an empty table without schema
1 participant