Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error handling of Table #147

Closed
lars-reimann opened this issue Apr 2, 2023 · 1 comment · Fixed by #308
Closed

Improve error handling of Table #147

lars-reimann opened this issue Apr 2, 2023 · 1 comment · Fixed by #308
Assignees
@Marsmaennchen221 @robmeth
Labels
documentation 📖 Improvements or additions to documentation enhancement 💡 New feature or request released Included in a release testing 🧪 Additional automated tests

Comments

@lars-reimann
Copy link
Member

lars-reimann commented Apr 2, 2023 •
edited
Loading

Is your feature request related to a problem?

In some cases, error handling is not ideal (see solution for details).

Desired solution

  • Validate inputs of a function as the first step
  • Raise an appropriate exception with an appropriate message if issues are found
  • Document in the docstring that the exception is raised and under which condition
  • Test that the correct exception with the correct message is raised

Possible alternatives (optional)

No response

Screenshots (optional)

No response

Additional Context (optional)

No response
@lars-reimann lars-reimann added the enhancement 💡 New feature or request label Apr 2, 2023
@github-project-automation github-project-automation bot moved this to Backlog in Library Apr 2, 2023
@lars-reimann lars-reimann changed the title Improve error handling Improve error handling in Table Apr 2, 2023
@lars-reimann lars-reimann added documentation 📖 Improvements or additions to documentation testing 🧪 Additional automated tests labels Apr 2, 2023
@lars-reimann lars-reimann changed the title Improve error handling in Table Improve error handling of Table Apr 2, 2023
@PhilipGutberlet PhilipGutberlet moved this from Backlog to Todo in Library May 12, 2023
@PhilipGutberlet PhilipGutberlet mentioned this issue May 12, 2023
Closed
@robmeth robmeth self-assigned this May 12, 2023
@Marsmaennchen221 Marsmaennchen221 self-assigned this May 12, 2023
@Marsmaennchen221 Marsmaennchen221 moved this from Todo to In Progress in Library May 12, 2023
@PhilipGutberlet PhilipGutberlet moved this from In Progress to Ready for Review in Library May 12, 2023
@PhilipGutberlet PhilipGutberlet moved this from Ready for Review to In Progress in Library May 12, 2023
@robmeth robmeth linked a pull request May 19, 2023 that will close this issue
feat: improve error handling of table #308
Merged
@robmeth robmeth mentioned this issue May 19, 2023
Merged
@Marsmaennchen221 Marsmaennchen221 moved this from In Progress to Ready for Review in Library May 19, 2023
PhilipGutberlet added a commit that referenced this issue May 25, 2023
@robmeth @Marsmaennchen221
@megalinter-bot @PhilipGutberlet
feat: improve error handling of table (#308)
ef87cc4 
Closes #147.

### Summary of Changes

feat: Added `WrongFileExtensionError`

* Validate inputs of a function as the first step
* Raise an appropriate exception with an appropriate message if issues
are found
* Document in the docstring that the exception is raised and under which
condition
* Test that the correct exception with the correct message is raised


Co-authored-by: Marsmaennchen221
<[email protected]>

---------

Co-authored-by: Alexander Gréus <[email protected]>
Co-authored-by: megalinter-bot <[email protected]>
Co-authored-by: Alexander <[email protected]>
Co-authored-by: Philip Gutberlet <[email protected]>
@github-project-automation github-project-automation bot moved this from Ready for Review to ✔️ Done in Library May 25, 2023
lars-reimann pushed a commit that referenced this issue Jun 1, 2023
@semantic-release-bot
chore(release): 0.13.0 [skip ci]
9a332b2 
## [0.13.0](v0.12.0...v0.13.0) (2023-06-01)

### Features

* add `Choice` class for possible values of hyperparameter ([#325](#325)) ([d511c3e](d511c3e)), closes [#264](#264)
* Add `RangeScaler` transformer ([#310](#310)) ([f687840](f687840)), closes [#141](#141)
* Add methods that tell which columns would be affected by a transformer ([#304](#304)) ([3933b45](3933b45)), closes [#190](#190)
* Getters for hyperparameters of Regression and Classification models ([#306](#306)) ([5c7a662](5c7a662)), closes [#260](#260)
* improve error handling of table ([#308](#308)) ([ef87cc4](ef87cc4)), closes [#147](#147)
* Remove warnings thrown in new `Transformer` methods ([#324](#324)) ([ca046c4](ca046c4)), closes [#323](#323)
@lars-reimann
Copy link
Member Author

🎉 This issue has been resolved in version 0.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Marsmaennchen221 Marsmaennchen221

@robmeth robmeth

Labels
documentation 📖 Improvements or additions to documentation enhancement 💡 New feature or request released Included in a release testing 🧪 Additional automated tests
Projects
Library
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: improve error handling of table Safe-DS/Library
3 participants
@lars-reimann @Marsmaennchen221 @robmeth