feat: Remove warnings thrown in new Transformer methods
#324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzril
changed the title
Transformer methods
…rmer-methods-added-in-304' into 323-remove-warnings-from-transformer-methods-added-in-304
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Codecov Report
@@ Coverage Diff @@
## main #324 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 44 44
Lines 1986 1975 -11
=========================================
- Hits 1986 1975 -11
|
sibre28
deleted the
323-remove-warnings-from-transformer-methods-added-in-304
branch
lars-reimann
pushed a commit
that referenced
this pull request
Jun 1, 2023
## [0.13.0](v0.12.0...v0.13.0) (2023-06-01) ### Features * add `Choice` class for possible values of hyperparameter ([#325](#325)) ([d511c3e](d511c3e)), closes [#264](#264) * Add `RangeScaler` transformer ([#310](#310)) ([f687840](f687840)), closes [#141](#141) * Add methods that tell which columns would be affected by a transformer ([#304](#304)) ([3933b45](3933b45)), closes [#190](#190) * Getters for hyperparameters of Regression and Classification models ([#306](#306)) ([5c7a662](5c7a662)), closes [#260](#260) * improve error handling of table ([#308](#308)) ([ef87cc4](ef87cc4)), closes [#147](#147) * Remove warnings thrown in new `Transformer` methods ([#324](#324)) ([ca046c4](ca046c4)), closes [#323](#323)
|
🎉 This PR is included in version 0.13.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #323.
Summary of Changes
Removed the warnings from
get_names_of_added_columns,get_names_of_changed_columnsandget_names_of_removed_columnsin all transformers.Updated tests accordingly.