feat: Memoization #38

WinPlay02 · 2024-01-17T17:09:25Z

added a memoization map that is shared between processes
added function to either call a function or return the memoized result
added function to convert a list to a tuple recursively and return the last modification time for a file
added tests

…tion # Conflicts: # src/safeds_runner/server/pipeline_manager.py

…tion

test: memoization

github-actions · 2024-01-17T17:10:53Z

🦙 MegaLinter status: ✅ SUCCESS

Descriptor	Linter	Files	Fixed	Errors	Elapsed time
✅ PYTHON	black	2	0	0	0.55s
✅ PYTHON	mypy	2		0	1.74s
✅ PYTHON	ruff	2	0	0	0.02s
✅ REPOSITORY	git_diff	yes		no	0.01s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by

codecov · 2024-01-17T17:11:12Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dae57dc) 100.00% compared to head (3d7f6b2) 100.00%.

Additional details and impacted files

@@            Coverage Diff            @@
##              main       #38   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          421       446   +25     
=========================================
+ Hits           421       446   +25

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

style: fixed more linter warnings

…test style: fixed more linter warnings

src/safeds_runner/server/pipeline_manager.py

…tion

Co-authored-by: Lars Reimann <[email protected]>

lars-reimann

Looks great, thank you.

## [0.5.0](v0.4.0...v0.5.0) (2024-01-26) ### Features * added json serializer that encodes tables and images ([#29](#29)) ([054cca4](054cca4)), closes [#20](#20) * Memoization ([#38](#38)) ([2a26b48](2a26b48)) * Replace flask with quart ([#43](#43)) ([5520b68](5520b68)), closes [#42](#42) * support placeholder queries that only request a subset of data ([#39](#39)) ([dae57dc](dae57dc)) * update to safe-ds 0.17.1 + server refactor ([#37](#37)) ([1bcad07](1bcad07)) ### Bug Fixes * allow multiple connections to work with the runner ([#31](#31)) ([64685a3](64685a3))

lars-reimann · 2024-01-26T12:18:08Z

🎉 This PR is included in version 0.5.0 🎉

The release is available on:

v0.5.0
GitHub release

Your semantic-release bot 📦🚀

Bumps [mkdocs-glightbox](https://github.com/Blueswen/mkdocs-glightbox) from 0.3.7 to 0.4.0. <details> <summary>Release notes</summary> Sourced from <a href="https://github.com/Blueswen/mkdocs-glightbox/releases">mkdocs-glightbox's releases</a>. <blockquote> <h2>mkdocs-glightbox-0.4.0</h2> <ul> <li>Supported manual mode (<a href="https://redirect.github.com/Blueswen/mkdocs-glightbox/issues/29">#29</a>)</li> <li>Allow calling lightbox methods from other places (<a href="https://redirect.github.com/Blueswen/mkdocs-glightbox/issues/34">#34</a>)</li> <li>Added id to appended script tag (<a href="https://redirect.github.com/Blueswen/mkdocs-glightbox/issues/38">#38</a>)</li> <li>Access theme attribute directly (<a href="https://redirect.github.com/Blueswen/mkdocs-glightbox/issues/40">#40</a>)</li> <li>Better JavaScript Error Handling (<a href="https://redirect.github.com/Blueswen/mkdocs-glightbox/issues/36">#36</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> Sourced from <a href="https://github.com/blueswen/mkdocs-glightbox/blob/main/CHANGELOG">mkdocs-glightbox's changelog</a>. <blockquote> mkdocs-glightbox-0.4.0 (2023-05-06) <pre><code>* Supported manual mode ([#29](blueswen/mkdocs-glightbox#29)) * Allow calling lightbox methods from other places ([#34](blueswen/mkdocs-glightbox#34)) * Added id to appended script tag ([#38](blueswen/mkdocs-glightbox#38)) * Access theme attribute directly ([#40](blueswen/mkdocs-glightbox#40)) * Better JavaScript Error Handling ([#36](blueswen/mkdocs-glightbox#36)) </code></pre> mkdocs-glightbox-0.3.7 (2023-01-24) <pre><code>* Supported custom background and shadow ([#27](blueswen/mkdocs-glightbox#27)) </code></pre> mkdocs-glightbox-0.3.6 (2023-12-30) <pre><code>* Modified width default to auto prevent zooming large image bug ([#21](blueswen/mkdocs-glightbox#21)) * Supported only enable glightbox with on-glb class in given page ([#28](blueswen/mkdocs-glightbox#28)) </code></pre> mkdocs-glightbox-0.3.5 (2023-11-18) <pre><code>* Supported compatibility with the privacy plugin of Material for MkDocs insiders ([#25](blueswen/mkdocs-glightbox#25)) </code></pre> mkdocs-glightbox-0.3.4 (2023-04-25) <pre><code>* Fixed regex bug: quote issue and empty alt issue ([#14](blueswen/mkdocs-glightbox#14) [#19](blueswen/mkdocs-glightbox#19)) </code></pre> mkdocs-glightbox-0.3.3 (2023-04-20) <pre><code>* Refactored processing logic with regex ([#14](blueswen/mkdocs-glightbox#14)) </code></pre> mkdocs-glightbox-0.3.2 (2023-03-19) <pre><code>* Supported image without extension ([#13](blueswen/mkdocs-glightbox#13)) </code></pre> mkdocs-glightbox-0.3.1 (2022-11-22) <pre><code>* Supported lightbox slide effect customization ([#8](blueswen/mkdocs-glightbox#8)) * Supported synchronized lightbox caption dark mode with Material for MkDocs ([#7](blueswen/mkdocs-glightbox#7)) * Supported glightbox built-in gallery feature ([#11](blueswen/mkdocs-glightbox#11)) * Supported skip image in the anchor tag </code></pre> mkdocs-glightbox-0.3.0 (2022-09-29) <pre><code>* Fixed width and height setting in config not working bug * Supported specific skip class ([#5](blueswen/mkdocs-glightbox#5)) * Supported glightbox built-in caption with title and description ([#4](blueswen/mkdocs-glightbox#4)) * Fixed page jitter when lightbox closing issue using Material for MkDocs * Add white background for lightbox images to prevent the displaying issue of the transparent image on black background </code></pre> mkdocs-glightbox-0.2.1 (2022-08-10)  </blockquote> ... (truncated) </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/blueswen/mkdocs-glightbox/commit/7f68f19556c8d91eb45bed2f5e3b93f9d0b4e591"><code>7f68f19</code></a> v0.4.0</li> <li><a href="https://github.com/blueswen/mkdocs-glightbox/commit/1409b0de89bd0aa930bbee0c2aa801c8b3391137"><code>1409b0d</code></a> Add manual mode</li> <li><a href="https://github.com/blueswen/mkdocs-glightbox/commit/e5ce7c9214f2de3647cbb1c9a1ec67bd82b387f9"><code>e5ce7c9</code></a> Add search plugin note</li> <li><a href="https://github.com/blueswen/mkdocs-glightbox/commit/d7747e7e1e58e8fe5868f38292bbb6a65f5ac902"><code>d7747e7</code></a> Merge pull request <a href="https://redirect.github.com/Blueswen/mkdocs-glightbox/issues/29">#29</a> from michalfapso/main</li> <li><a href="https://github.com/blueswen/mkdocs-glightbox/commit/6895d4eb60ef383530f8a807bec19404342a74c3"><code>6895d4e</code></a> Add test case</li> <li><a href="https://github.com/blueswen/mkdocs-glightbox/commit/dc38a6c042da9dcf949a594940f312cfbf5cc1ae"><code>dc38a6c</code></a> try catch prevent Uncaught TypeError (<a href="https://redirect.github.com/Blueswen/mkdocs-glightbox/issues/36">#36</a>)</li> <li><a href="https://github.com/blueswen/mkdocs-glightbox/commit/7d2c0ab4b214759f7ab22ab9e775c609718ad061"><code>7d2c0ab</code></a> access theme attribute directly (<a href="https://redirect.github.com/Blueswen/mkdocs-glightbox/issues/40">#40</a>)</li> <li><a href="https://github.com/blueswen/mkdocs-glightbox/commit/b0b63f8fa2bfbd14812c95b466af180e34db2cc4"><code>b0b63f8</code></a> Merge pull request <a href="https://redirect.github.com/Blueswen/mkdocs-glightbox/issues/34">#34</a> from AndBondStyle/main</li> <li><a href="https://github.com/blueswen/mkdocs-glightbox/commit/8e652652429851d18a0c920ca1ddcbf12ab71fdf"><code>8e65265</code></a> update validation condition</li> <li><a href="https://github.com/blueswen/mkdocs-glightbox/commit/4963fdb93c4f483827bcab10c5289452068e1fb5"><code>4963fdb</code></a> Merge branch 'main' into main</li> <li>Additional commits viewable in <a href="https://github.com/Blueswen/mkdocs-glightbox/compare/v0.3.7...v0.4.0">compare view</a></li> </ul> </details> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=mkdocs-glightbox&package-manager=pip&previous-version=0.3.7&new-version=0.4.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

WinPlay02 added 4 commits January 10, 2024 13:40

feat: memoization preview 1

748ec56

Merge branch 'main' of https://github.com/Safe-DS/Runner into memoiza…

f39bb68

…tion # Conflicts: # src/safeds_runner/server/pipeline_manager.py

Merge branch 'main' of https://github.com/Safe-DS/Runner into memoiza…

4728fcf

…tion

feat: memoization

5487336

test: memoization

WinPlay02 and others added 6 commits January 17, 2024 18:46

style: fixed linter warnings

ecfabae

test: added filemtime tests

9b6aa86

style: fixed more linter warnings

test: use NamedTemporaryFile instead of TemporaryFile for file mtime …

eeb3da3

…test style: fixed more linter warnings

style: fixed datetime linter warning

1e92e86

style: apply automated linter fixes

ffc46ac

style: apply automated linter fixes

88db274

WinPlay02 marked this pull request as ready for review January 22, 2024 02:29

WinPlay02 requested a review from a team as a code owner January 22, 2024 02:29

lars-reimann requested changes Jan 24, 2024

View reviewed changes

src/safeds_runner/server/pipeline_manager.py Outdated Show resolved Hide resolved

src/safeds_runner/server/pipeline_manager.py Outdated Show resolved Hide resolved

src/safeds_runner/server/pipeline_manager.py Outdated Show resolved Hide resolved

WinPlay02 and others added 2 commits January 24, 2024 15:36

Merge branch 'main' of https://github.com/Safe-DS/Runner into memoiza…

55388be

…tion

misc: address review comments

3d7f6b2

Co-authored-by: Lars Reimann <[email protected]>

WinPlay02 requested a review from lars-reimann January 24, 2024 14:45

lars-reimann approved these changes Jan 24, 2024

View reviewed changes

lars-reimann merged commit 2a26b48 into main Jan 24, 2024
7 checks passed

lars-reimann deleted the memoization branch January 24, 2024 14:48

lars-reimann added the released Included in a release label Jan 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Memoization #38

feat: Memoization #38

WinPlay02 commented Jan 17, 2024

github-actions bot commented Jan 17, 2024 •

edited

Loading

codecov bot commented Jan 17, 2024 •

edited

Loading

lars-reimann left a comment

lars-reimann commented Jan 26, 2024

feat: Memoization #38

feat: Memoization #38

Conversation

WinPlay02 commented Jan 17, 2024

github-actions bot commented Jan 17, 2024 • edited Loading

🦙 MegaLinter status: ✅ SUCCESS

codecov bot commented Jan 17, 2024 • edited Loading

Codecov Report

lars-reimann left a comment

Choose a reason for hiding this comment

lars-reimann commented Jan 26, 2024

github-actions bot commented Jan 17, 2024 •

edited

Loading

codecov bot commented Jan 17, 2024 •

edited

Loading