-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sending images to the vscode extension fails, if the tensor is not local to the cpu #63
Conversation
…ot local to the cpu
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #63 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 11
Lines 500 504 +4
=========================================
+ Hits 500 504 +4 ☔ View full report in Codecov by Sentry. |
@SmiteDeluxe The PR for the fix we talked about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good. I cannot currently verify, though, whether this fixes the issue. Still, feel free to merge if you've checked this.
As I'm not affected by this, @SmiteDeluxe would be able to verify and merge this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working for me with this change!
## [0.8.0](v0.7.0...v0.8.0) (2024-04-03) ### Features * **deps:** bump safe-ds from 0.19.0 to 0.20.0 ([#74](#74)) ([86cccff](86cccff)), closes [#573](https://github.com/Safe-DS/Runner/issues/573) [#529](https://github.com/Safe-DS/Runner/issues/529) [#522](https://github.com/Safe-DS/Runner/issues/522) [#588](https://github.com/Safe-DS/Runner/issues/588) [#548](https://github.com/Safe-DS/Runner/issues/548) [#519](https://github.com/Safe-DS/Runner/issues/519) [#550](https://github.com/Safe-DS/Runner/issues/550) [#549](https://github.com/Safe-DS/Runner/issues/549) [#572](https://github.com/Safe-DS/Runner/issues/572) [#571](https://github.com/Safe-DS/Runner/issues/571) [#567](https://github.com/Safe-DS/Runner/issues/567) [#587](https://github.com/Safe-DS/Runner/issues/587) [#582](https://github.com/Safe-DS/Runner/issues/582) [#585](https://github.com/Safe-DS/Runner/issues/585) [#573](https://github.com/Safe-DS/Runner/issues/573) [#529](https://github.com/Safe-DS/Runner/issues/529) [#522](https://github.com/Safe-DS/Runner/issues/522) [#588](https://github.com/Safe-DS/Runner/issues/588) [#548](https://github.com/Safe-DS/Runner/issues/548) [#519](https://github.com/Safe-DS/Runner/issues/519) [#550](https://github.com/Safe-DS/Runner/issues/550) [#549](https://github.com/Safe-DS/Runner/issues/549) [#572](https://github.com/Safe-DS/Runner/issues/572) [#571](https://github.com/Safe-DS/Runner/issues/571) [#567](https://github.com/Safe-DS/Runner/issues/567) [#587](https://github.com/Safe-DS/Runner/issues/587) [#582](https://github.com/Safe-DS/Runner/issues/582) [#585](https://github.com/Safe-DS/Runner/issues/585) [#605](https://github.com/Safe-DS/Runner/issues/605) [#604](https://github.com/Safe-DS/Runner/issues/604) [#603](https://github.com/Safe-DS/Runner/issues/603) [#593](https://github.com/Safe-DS/Runner/issues/593) [#598](https://github.com/Safe-DS/Runner/issues/598) [#595](https://github.com/Safe-DS/Runner/issues/595) [#594](https://github.com/Safe-DS/Runner/issues/594) [#591](https://github.com/Safe-DS/Runner/issues/591) [#590](https://github.com/Safe-DS/Runner/issues/590) ### Bug Fixes * sending images to the vscode extension fails, if the tensor is not local to the cpu ([#63](#63)) ([8cf0b57](8cf0b57)) ### Performance Improvements * faster startup ([#55](#55)) ([a3fbe24](a3fbe24))
🎉 This PR is included in version 0.8.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Closes #929 ### Summary of Changes Communication from EDA -> Runner in own file that allows appending of code to the executed pipeline to get and generate new info. This results in full profiling being done already, fetched when needed and displayed in webview. Also includes start of from webview triggered actions that append code, in the form of filters. But this is to be picked up in new issue. Other changes include refactorings and fixes for visual and edge case bugs. ### Important to run this: Some environments might need a change in the runner for images (plots) to work, that will be pushed to the Runner repo in PR Safe-DS/Runner#63. To PipelineManager: ``` from safeds.data.image.containers import Image import torch ``` To beginning of save_placeholder method: ``` if isinstance(value, Image): value = Image(value._image_tensor, torch.device("cpu")) ``` --------- Co-authored-by: Lars Reimann <[email protected]> Co-authored-by: WinPlay02 <[email protected]> Co-authored-by: megalinter-bot <[email protected]>
Related-to: Safe-DS/DSL#954 (the PR requires this fix to work)
Fixes the following error:
RuntimeError: Attempted to send CUDA tensor received from another process; this is not currently supported. Consider cloning before sending.
This error only occurs on systems that support graphics acceleration of tensor operations.
On other systems, the tensor is local to the CPU by default and does not need to be converted.
The conversion process is a noop, if the tensor is already local to the CPU.