Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDA: Create logic for appending code to pipelines #929

Closed
SmiteDeluxe opened this issue Feb 29, 2024 · 1 comment · Fixed by #954
Closed

EDA: Create logic for appending code to pipelines #929

SmiteDeluxe opened this issue Feb 29, 2024 · 1 comment · Fixed by #954
Assignees
Labels
enhancement 💡 New feature or request released Included in a release vscode 🔨 Issues regarding tools like the VS Code extension
Milestone

Comments

@SmiteDeluxe
Copy link
Contributor

  1. Webview triggers for actions that manipulate data
  2. VS Code to pick those up
  3. Extend code to pipeline and execute
  4. Get and send new placeholders to webview to update
@lars-reimann lars-reimann added this to DSL Feb 29, 2024
@github-project-automation github-project-automation bot moved this to Backlog in DSL Feb 29, 2024
@SmiteDeluxe SmiteDeluxe added enhancement 💡 New feature or request vscode 🔨 Issues regarding tools like the VS Code extension labels Feb 29, 2024
@SmiteDeluxe SmiteDeluxe self-assigned this Feb 29, 2024
@SmiteDeluxe SmiteDeluxe linked a pull request Mar 30, 2024 that will close this issue
@lars-reimann lars-reimann added this to the v0.10.0 milestone Apr 3, 2024
lars-reimann added a commit that referenced this issue Apr 6, 2024
Closes #929 

### Summary of Changes

Communication from EDA -> Runner in own file that allows appending of
code to the executed pipeline to get and generate new info.
This results in full profiling being done already, fetched when needed
and displayed in webview.
Also includes start of from webview triggered actions that append code,
in the form of filters. But this is to be picked up in new issue.

Other changes include refactorings and fixes for visual and edge case
bugs.

### Important to run this:
Some environments might need a change in the runner for images (plots)
to work, that will be pushed to the Runner repo in PR
Safe-DS/Runner#63.

To PipelineManager:
```
from safeds.data.image.containers import Image
import torch
```
To beginning of save_placeholder method:
```
if isinstance(value, Image):
    value = Image(value._image_tensor, torch.device("cpu"))
```

---------

Co-authored-by: Lars Reimann <[email protected]>
Co-authored-by: WinPlay02 <[email protected]>
Co-authored-by: megalinter-bot <[email protected]>
@github-project-automation github-project-automation bot moved this from Backlog to ✔️ Done in DSL Apr 6, 2024
lars-reimann pushed a commit that referenced this issue Apr 6, 2024
## [0.10.0](v0.9.0...v0.10.0) (2024-04-06)

### Features

* add settings to enable inlay hints individually ([#992](#992)) ([b0f3e62](b0f3e62))
* filter suggestions by node type ([#999](#999)) ([8d22e67](8d22e67)), closes [#998](#998)
* forbid instance and static class members with same name ([#988](#988)) ([7fa6fd4](7fa6fd4))
* improved completion provider ([#997](#997)) ([61e776b](61e776b)), closes [#41](#41)
* inlay hints for inferred types of lambda parameters ([#993](#993)) ([c064e0e](c064e0e))
* mark entire type cast as wrong if cast is impossible ([#991](#991)) ([72d4e2e](72d4e2e))
* profiling in EDA tool ([#954](#954)) ([854122c](854122c)), closes [#929](#929)
* require `safe-ds-runner>=0.8.0,<0.9.0` ([#976](#976)) ([1003e6c](1003e6c))
* resolve name paths in `{[@link](https://github.com/link) }` tags in documentation ([#978](#978)) ([b59d6f0](b59d6f0))

### Bug Fixes

* catch internal errors caused by wrong synthetic nodes created by completion provider ([#1001](#1001)) ([8a6ab99](8a6ab99))
* chained memoized calls ([#987](#987)) ([df89291](df89291))
* correctly import declarations for member functions ([#983](#983)) ([79f9b08](79f9b08))
* error in Python generator for assignments with class/enum variant call as RHS ([#977](#977)) ([46b2bb2](46b2bb2)), closes [#975](#975)
* generation of memoized class member calls ([#982](#982)) ([ed06aef](ed06aef))
* generation of Python imports ([#979](#979)) ([f69d836](f69d836)), closes [#974](#974)
* invalid Python code generated for constructor calls ([#981](#981)) ([c7d006f](c7d006f)), closes [#980](#980)
* Python generation for type casts ([#1000](#1000)) ([621ab86](621ab86))
@lars-reimann
Copy link
Member

🎉 This issue has been resolved in version 0.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 💡 New feature or request released Included in a release vscode 🔨 Issues regarding tools like the VS Code extension
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants