Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message type to shut down runner process gracefully #24

Closed
WinPlay02 opened this issue Dec 4, 2023 · 1 comment · Fixed by #25
Closed

Message type to shut down runner process gracefully #24

WinPlay02 opened this issue Dec 4, 2023 · 1 comment · Fixed by #25
Assignees
@WinPlay02
Labels
enhancement 💡 New feature or request released Included in a release

Comments

@WinPlay02
Copy link
Contributor

Is your feature request related to a problem?

On Windows systems, the runner cannot be gracefully shutdown, which leaves the SyncManager process behind.

Desired solution

A new message type (e.g. shutdown) that tells the runner to gracefully exit as soon as possible.

Possible alternatives (optional)

  • Using SIGINT, which does not exist on Windows. There is a CtrlBreak feature which could be used, but as I understood is not part of the Windows API and thus is hard to use in the extension. It is currently used when Ctrl+C is pressed and the process is run in a console window.
  • Just kill the whole process tree when the runner should be shut down.

Screenshots (optional)

No response

Additional Context (optional)

Killing the process tree could still be used as a last resort, if after sending the shutdown message, a specific timeout expired and the process didn't shut down in time.
@WinPlay02 WinPlay02 added the enhancement 💡 New feature or request label Dec 4, 2023
@lars-reimann lars-reimann added this to DSL Dec 4, 2023
@github-project-automation github-project-automation bot moved this to Backlog in DSL Dec 4, 2023
@WinPlay02 WinPlay02 moved this from Backlog to In Progress in DSL Dec 4, 2023
@WinPlay02 WinPlay02 self-assigned this Dec 4, 2023
@WinPlay02 WinPlay02 mentioned this issue Dec 4, 2023
Merged
lars-reimann added a commit that referenced this issue Dec 5, 2023
@WinPlay02 @megalinter-bot @lars-reimann
feat: shutdown messages (#25)
93fcb85 
Closes #24

### Summary of Changes

- added a shutdown message type that can be sent by the extension to
gracefully shut down the runner
- the sync child process should be shut down when sending a shutdown
message

---------

Co-authored-by: megalinter-bot <[email protected]>
Co-authored-by: Lars Reimann <[email protected]>
@github-project-automation github-project-automation bot moved this from In Progress to ✔️ Done in DSL Dec 5, 2023
lars-reimann pushed a commit that referenced this issue Dec 5, 2023
@semantic-release-bot
chore(release): 0.4.0 [skip ci]
7ed7c5c 
## [0.4.0](v0.3.0...v0.4.0) (2023-12-05)

### Features

* shutdown messages ([#25](#25)) ([93fcb85](93fcb85)), closes [#24](#24)

### Bug Fixes

* race condition when initializing multiprocessing manager ([#26](#26)) ([fc5934f](fc5934f)), closes [#18](#18)
@lars-reimann
Copy link
Member

🎉 This issue has been resolved in version 0.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WinPlay02 WinPlay02

Labels
enhancement 💡 New feature or request released Included in a release
Projects
DSL
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: shutdown messages Safe-DS/Runner
2 participants
@lars-reimann @WinPlay02