Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Handle UserWarnings correctly in tests #417

Merged
merged 13 commits into from
Jul 7, 2023

Conversation

zzril
Copy link
Contributor

@zzril zzril commented Jul 4, 2023

Closes #399.

Summary of Changes

  • Ignore the UserWarning about data being already numerical thrown by OneHotEncoder in nan testcase.
  • Ignore UserWarnings about multiple most common values existing thrown by Imputer in testcases that are not meant to test for warnings.

@zzril zzril linked an issue Jul 4, 2023 that may be closed by this pull request
@zzril zzril changed the title testing: Handle UserWarnings correctly in tests test: Handle UserWarnings correctly in tests Jul 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 2 0 0 0.85s
✅ PYTHON mypy 2 0 1.59s
✅ PYTHON ruff 2 0 0 0.1s
✅ REPOSITORY git_diff yes no 0.08s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #417 (17ad3f5) into main (1e903d3) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #417   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           47        47           
  Lines         2369      2369           
=========================================
  Hits          2369      2369           

@zzril zzril marked this pull request as ready for review July 4, 2023 15:41
@zzril zzril requested a review from a team as a code owner July 4, 2023 15:41
@zzril zzril merged commit 388ab2d into main Jul 7, 2023
@zzril zzril deleted the 399-userwarnings-thrown-in-in-test-suite branch July 7, 2023 07:18
@lars-reimann
Copy link
Member

🎉 This PR is included in version 0.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UserWarnings thrown in in test suite
4 participants