-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always specify explicitly that methods do not change an object in place but return a new one #189
Comments
Some of the methods of |
As discussed, the |
#279) Closes #189. ### Summary of Changes Highlighting the fact, that fitting methods of Classifier, Regressor, Tabletransformer and certain methods of the _table class do not work in place. --------- Co-authored-by: Lars Reimann <[email protected]> Co-authored-by: megalinter-bot <[email protected]>
🎉 This issue has been resolved in version 0.12.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Users that are coming from other libraries like
scikit-learn
could easily forget that methods likefit
do not work in place but return a new, fitted model/transformer.We should always highlight this in the docstrings of these methods. This includes
fit
methods ofTableTransformer
sfit
methods ofClassifier
sfit
methods ofRegressor
sTable
that return aTable
.See https://stdlib.safe-ds.com/en/latest/development/guidelines/#document-api-elements for the required docstring format.
The text was updated successfully, but these errors were encountered: