-
Notifications
You must be signed in to change notification settings - Fork 4
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
### Summary of Changes The `OrdinalEncoder` was a bit of an outlier compared to the other `Transformer` classes: * It could only be applied to a single column instead of a list of columns. Because of this, it was not possible to implement #61. * Nothing was "learned" since the user had to specify the value order explicitly. The `fit` step was completely unnecessary. Therefore, I've removed the class `OrdinalEncoder`. Instead the `transform_column` method on a `Table` can be used. If eventually find this to be too cumbersome, we can implement a new method `transform_column_into_ordered_labels` on `Table`. --------- Co-authored-by: lars-reimann <[email protected]>
- Loading branch information
1 parent
fe68426
commit b92bba5
Showing
7 changed files
with
19 additions
and
308 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,3 @@ | ||
from ._imputer import Imputer | ||
from ._label_encoder import LabelEncoder | ||
from ._one_hot_encoder import OneHotEncoder | ||
from ._ordinal_encoder import OrdinalEncoder |
144 changes: 0 additions & 144 deletions
144
src/safeds/data/tabular/transformation/_ordinal_encoder.py
This file was deleted.
Oops, something went wrong.
Empty file.
50 changes: 0 additions & 50 deletions
50
tests/safeds/data/tabular/transformation/_ordinal_encoder/test_fit_transform.py
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.