more test cases, modified error message

Safe-DS · Jul 13, 2023 · ac8ccb0 · ac8ccb0
1 parent ebc1261
commit ac8ccb0
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 6 deletions.
diff --git a/src/safeds/exceptions/_data.py b/src/safeds/exceptions/_data.py
@@ -23,11 +23,12 @@ class _UnknownColumnNameErrorMessage(
             def __repr__(self) -> str:
                 return str(self)
 
-        super().__init__(
-            _UnknownColumnNameErrorMessage(
-                f"Could not find column(s) '{', '.join(column_names)}'.\nDid you mean '{similar_columns}'?",
-            ),
-        )
+        error_message = f"Could not find column(s) '{', '.join(column_names)}'."
+
+        if similar_columns is not None:
+            error_message += f"\nDid you mean '{similar_columns}'?"
+
+        super().__init__(_UnknownColumnNameErrorMessage(error_message))
 
 
 class NonNumericColumnError(Exception):

diff --git a/tests/safeds/data/tabular/containers/_table/test_get_similar_columns.py b/tests/safeds/data/tabular/containers/_table/test_get_similar_columns.py
@@ -20,8 +20,19 @@
             "clumn1",
             ["column1", "cilumn2"],
         ),
+        (
+            Table({"column1": ["col1_1"], "x": ["y"], "cilumn2": ["cil2_1"]}),
+            "notexisting",
+            ["x"],
+        ),
+        (
+            Table({"column1": ["col1_1"], "x": ["y"], "cilumn2": ["cil2_1"]}),
+            "x",
+            ["x"],
+        ),
+        (Table({}), "column1", []),
     ],
-    ids=["one similar", "two similar/ dynamic increase"],
+    ids=["one similar", "two similar/ dynamic increase", "no similar", "exact match", "empty table"],
 )
 def test_should_get_similar_column_names(table: Table, column_name: str, expected: list[str]) -> None:
     assert table._get_similar_columns(column_name) == expected