Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: compatibility with safe-ds v0.17.0 #121

Merged
merged 4 commits into from
Jan 11, 2024
Merged

feat: compatibility with safe-ds v0.17.0 #121

merged 4 commits into from
Jan 11, 2024

Conversation

lars-reimann
Copy link
Member

Summary of Changes

Integrate API changes of safe-ds v0.17.0.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 11, 2024 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ REPOSITORY git_diff yes no 0.03s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@lars-reimann
Copy link
Member Author

lars-reimann commented Jan 11, 2024 •
edited
Loading

@Marsmaennchen221 Do you have an idea how to fix this error (log)?

OSError: libcurand.so.10: cannot open shared object file: No such file or directory

It occurs after targeting the Safe-DS version that includes the tensor-based images. Apparently, the library tries to access CUDA, even though it's not available.

Update 1: It looks like v2.0.1 has issues: pytorch/pytorch#100974

Update 2: Upgrading torch to v2.1.2 resolved the issue.

@lars-reimann
build: update lockfile
4bb3d95
@lars-reimann
ci: drop support for Python 3.12
232109a 
We have to do this temporarily as `torch` does not support it yet
@codecov Codecov
Copy link

codecov bot commented Jan 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7973c4d) 100.00% compared to head (232109a) 100.00%.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #121   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines           38        38           
=========================================
  Hits            38        38

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lars-reimann lars-reimann merged commit bd12659 into main Jan 11, 2024
7 checks passed
@lars-reimann lars-reimann deleted the 0.17.0 branch January 11, 2024 13:19
lars-reimann pushed a commit that referenced this pull request Jan 11, 2024
@semantic-release-bot
chore(release): 0.17.0 [skip ci]
de37a6c 
## [0.17.0](v0.16.0...v0.17.0) (2024-01-11)

### Features

* compatibility with safe-ds v0.17.0 ([#121](#121)) ([bd12659](bd12659))
@lars-reimann
Copy link
Member Author

🎉 This PR is included in version 0.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Jan 11, 2024
@lars-reimann
Copy link
Member Author

@WinPlay02 You can change main.yml and pr.yml in the runner as done in this PR to temporarily disable the Python 3.12 build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released Included in a release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lars-reimann