fix: NPEs during validation #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Codecov Report
@@ Coverage Diff @@
## main #727 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 74 74
Lines 10445 10448 +3
Branches 2263 2262 -1
=========================================
+ Hits 10445 10448 +3
|
lars-reimann
pushed a commit
that referenced
this pull request
Nov 12, 2023
## [0.3.0](v0.2.0...v0.3.0) (2023-11-12) ### Features * annotations for the purity of functions ([#709](#709)) ([9d342e4](9d342e4)), closes [#559](#559) * call hierarchy provider ([#735](#735)) ([168d098](168d098)), closes [#680](#680) * compute type of elvis operators with nullable left operand ([#715](#715)) ([376b083](376b083)), closes [#541](#541) * customize rendering of `[@param](https://github.com/param)`, `[@Result](https://github.com/result)`, and `[@type](https://github.com/type)Param` tags ([#764](#764)) ([e049148](e049148)), closes [#669](#669) * ensure an overriding member matches the overridden one ([#758](#758)) ([a698a6a](a698a6a)), closes [#639](#639) * error if callable type is used in wrong context ([#763](#763)) ([9b1522f](9b1522f)), closes [#713](#713) * error if type parameter is used in nested named type declaration ([#750](#750)) ([52374aa](52374aa)), closes [#748](#748) * info if overriding member is not needed ([#759](#759)) ([23b340e](23b340e)), closes [#25](#25) * mark constraint lists as experimental ([#752](#752)) ([d48e1e0](d48e1e0)), closes [#18](#18) * mark type parameter lists and type argument lists as experimental ([#755](#755)) ([f1a052a](f1a052a)), closes [#753](#753) * mark unused internal/private segments as unnecessary ([#710](#710)) ([3ba8698](3ba8698)), closes [#682](#682) * minor improvements for purity info ([#728](#728)) ([8d59607](8d59607)) * partially evaluate lambdas and segments ([#734](#734)) ([c40347c](c40347c)), closes [#603](#603) * scoping for inherited members ([#706](#706)) ([4518aee](4518aee)), closes [#540](#540) * scoping for member access on literals and literal types ([#754](#754)) ([e60e456](e60e456)), closes [#80](#80) * scoping for references to containing declarations ([#708](#708)) ([3762c36](3762c36)), closes [#540](#540) * show an error if a pure parameter does not have a callable type ([#736](#736)) ([6c52868](6c52868)), closes [#729](#729) * show error if own declaration has same name as core one ([#762](#762)) ([8cb2120](8cb2120)), closes [#760](#760) * signature help ([#724](#724)) ([ed33676](ed33676)), closes [#24](#24) * Source Maps for Code Generation ([#714](#714)) ([64b9e07](64b9e07)), closes [#30](#30) * tooltips for inlay hints ([#721](#721)) ([3e71cad](3e71cad)) * type checker service ([#722](#722)) ([daad5c4](daad5c4)), closes [#666](#666) * type checking ([#723](#723)) ([a9eb3bb](a9eb3bb)), closes [#666](#666) * type checking for list & map literals ([#751](#751)) ([dc14223](dc14223)), closes [#712](#712) * type hierarchy provider ([#737](#737)) ([9fd5f0c](9fd5f0c)), closes [#681](#681) * VS Code snippets ([#757](#757)) ([fd6f432](fd6f432)), closes [#756](#756) ### Bug Fixes * assignability of static type to callable type ([#725](#725)) ([1d17900](1d17900)) * NPEs during validation ([#727](#727)) ([4b8196f](4b8196f)) * prevent overwriting core declarations ([#761](#761)) ([36663ca](36663ca)) * prevent references to following parameters from default values ([#707](#707)) ([182d64b](182d64b)), closes [#540](#540) * setup of CLI ([#698](#698)) ([0b5d90d](0b5d90d))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fix several NPEs that could occur during validation because the node passed to the acceptor might be
undefined. Instead of setting theproperty, as should normally be done, we access the child node directly, since this gives us the correct range.