Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Minor fixes for visualization tutorial, summary & heatmap #391

Merged
merged 7 commits into from
Jan 31, 2023

Conversation

SmiteDeluxe
Copy link
Contributor

Summary of Changes

Fixed the visualization tutorial with discussed changes from #380 as well as 3 of the bullet points from #381 (namely summary header, summary all string and heatmap color scheme).

@github-actions
Copy link

github-actions bot commented Jan 29, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ MARKDOWN markdown-link-check 1 0 0.69s
✅ PYTHON bandit 3 0 0.75s
✅ PYTHON black 3 0 0 0.93s
✅ PYTHON flake8 3 0 0.54s
✅ PYTHON isort 3 0 0 0.33s
✅ PYTHON mypy 3 0 2.34s
✅ PYTHON pylint 3 0 3.36s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@SmiteDeluxe SmiteDeluxe merged commit 4926613 into main Jan 31, 2023
@SmiteDeluxe SmiteDeluxe deleted the minor_fixes branch January 31, 2023 00:09
lars-reimann added a commit that referenced this pull request Jan 31, 2023
### Summary of Changes

Running only the tests of changed components leads to incorrect coverage
reports and prevents us from making the tests required. The latter
allows PR with failing tests to be merged, like #391.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants