Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show default values of parameters in signature help #1251

Merged

Conversation

lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented Nov 1, 2024

Closes #1147

Summary of Changes

Show default values of parameters in the signature help. Previously, it only showed whether a parameter was optional or not.

@lars-reimann lars-reimann linked an issue Nov 1, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Nov 1, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ REPOSITORY git_diff yes no 0.06s
✅ TYPESCRIPT eslint 2 0 0 4.58s
✅ TYPESCRIPT prettier 2 0 0 0.61s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.68%. Comparing base (5913a54) to head (2de73d7).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1251      +/-   ##
==========================================
- Coverage   99.68%   99.68%   -0.01%     
==========================================
  Files         110      110              
  Lines       12577    12573       -4     
  Branches     4142     4141       -1     
==========================================
- Hits        12538    12534       -4     
  Misses         39       39              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lars-reimann lars-reimann merged commit ff8fa13 into main Nov 1, 2024
9 checks passed
@lars-reimann lars-reimann deleted the 1147-show-default-values-of-parameters-in-tooltips branch November 1, 2024 11:29
lars-reimann pushed a commit that referenced this pull request Nov 1, 2024
## [0.20.0](v0.19.0...v0.20.0) (2024-11-01)

### Features

* indexed access for columns and rows ([#1252](#1252)) ([896165a](896165a))
* show default values of parameters in signature help ([#1251](#1251)) ([ff8fa13](ff8fa13)), closes [#1147](#1147)
@lars-reimann
Copy link
Member Author

🎉 This PR is included in version 0.20.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show default values of parameters in tooltips
1 participant