Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow use of operators for cells #1247

Merged
merged 9 commits into from
Oct 31, 2024
Merged

feat: allow use of operators for cells #1247

merged 9 commits into from
Oct 31, 2024

Conversation

lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented Oct 31, 2024 •
edited
Loading

Closes #1165

Summary of Changes

Operators can now also be used if the operands are cells, leading to considerably more readable code when working with cells.

Before:

val bothN = tableShortN.countRowIf(
    (row) -> (row.getValue("survived").eq("Yes")).^and
             (row.getValue("age").gt(30))
)

After:

val bothN = tableShortN.countRowIf(
    (row) -> row.getValue("survived") == "Yes" and
             row.getValue("age") > 30
)

The old named methods will remain part of the API, so they show up in auto-completion and the API reference and guide users towards the corresponding operators.

@lars-reimann lars-reimann linked an issue Oct 31, 2024 that may be closed by this pull request
Allow use of operators for cells #1165
Closed
@github-actions GitHub Actions
Copy link

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ REPOSITORY git_diff yes no 0.14s
✅ TYPESCRIPT eslint 7 0 0 5.19s
✅ TYPESCRIPT prettier 7 0 0 1.54s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@lars-reimann lars-reimann merged commit 2930357 into main Oct 31, 2024
6 checks passed
@lars-reimann lars-reimann deleted the 1165-allow-use-of-operators-for-cells branch October 31, 2024 16:23
lars-reimann pushed a commit that referenced this pull request Oct 31, 2024
@semantic-release-bot
chore(release): 0.19.0 [skip ci]
a3a907a 
## [0.19.0](v0.18.0...v0.19.0) (2024-10-31)

### Features

* allow use of operators for cells ([#1247](#1247)) ([2930357](2930357)), closes [#1165](#1165)
* show "print" code lens for some nullable types ([#1248](#1248)) ([492120c](492120c))

### Bug Fixes

* generate code for receivers outside of block lambdas ([#1246](#1246)) ([0d27e33](0d27e33))
@lars-reimann
Copy link
Member Author

🎉 This PR is included in version 0.19.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released Included in a release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow use of operators for cells
1 participant
@lars-reimann