fix: generate code for receivers outside of block lambdas #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Placeholders need a prefix, so they don't clash with Python keywords. The previous prefix, however, was a prefix of the prefixes used for receivers, yields, etc. Because of this, collisions were possible, e.g. if the user called their placeholder `receiver_0`.
For block lambdas, some method receivers are generated inside the lambda, rather than outside.
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1246 +/- ##
=======================================
Coverage 99.68% 99.68%
=======================================
Files 110 110
Lines 12487 12489 +2
Branches 4110 4110
=======================================
+ Hits 12448 12450 +2
Misses 39 39 ☔ View full report in Codecov by Sentry. |
lars-reimann
pushed a commit
that referenced
this pull request
Oct 31, 2024
## [0.19.0](v0.18.0...v0.19.0) (2024-10-31) ### Features * allow use of operators for cells ([#1247](#1247)) ([2930357](2930357)), closes [#1165](#1165) * show "print" code lens for some nullable types ([#1248](#1248)) ([492120c](492120c)) ### Bug Fixes * generate code for receivers outside of block lambdas ([#1246](#1246)) ([0d27e33](0d27e33))
|
🎉 This PR is included in version 0.19.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The code that was generated for the following example was wrong:
The code that was created for
rawDatawas inside the body of the function created for the block lambda. Later references torawDatawere, thus, unresolved.