style: change method call expression style

SaeedBolhasani · May 28, 2024 · a47ffac · a47ffac
1 parent cca39c3
commit a47ffac
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/src/SpelParser/SpelGrammerCompiler.cs b/src/SpelParser/SpelGrammerCompiler.cs
@@ -96,14 +96,14 @@ private MethodCallExpression CreateCallCompareToMethodExpression(FieldContext fi
             var constant = Convert.ChangeType(Enum.Parse(fieldType, GetString(constantContext), true), underlyingType);
             fieldExpression = Expression.Convert(fieldExpression, underlyingType);
             fieldType = underlyingType;
-            constantExpression = Expression.Constant(constant);           
+            constantExpression = Expression.Constant(constant);
         }
         else
         {
             constantExpression = CreateValueExpression(fieldType, constantContext);
         }
 
-        return Expression.Call(fieldExpression, fieldType.GetMethod("CompareTo", [fieldType])!, constantExpression);
+        return Expression.Call(fieldExpression, fieldType.GetMethod(nameof(IComparable.CompareTo), [fieldType])!, constantExpression);
     }
 
     private Expression CreateValueExpression(Type fieldExpression, ConstantContext constantContext)
@@ -113,10 +113,9 @@ private Expression CreateValueExpression(Type fieldExpression, ConstantContext c
         if (fieldExpression == typeof(string))
             return constantExpression;
 
-        if (fieldExpression.GetMethod("Parse", [typeof(string)]) != null)
-            return Expression.Call(fieldExpression, "Parse", Type.EmptyTypes, constantExpression);
+        var methodCallExpression = fieldExpression.GetMethod("Parse", [typeof(string)]) ?? throw new ArgumentException("Unknown type", fieldExpression.ToString());
 
-        throw new ArgumentException("Unknown type", fieldExpression.ToString());
+        return Expression.Call(methodCallExpression, constantExpression);
     }
 
     public Expression<Func<T, bool>> CreateFunc(string input)

diff --git a/src/SpelParser/SpelParser.csproj b/src/SpelParser/SpelParser.csproj
@@ -3,9 +3,9 @@
 	<PropertyGroup>
 		<TargetFramework>net8.0</TargetFramework>
 		<Nullable>enable</Nullable>
-		<PackageVersion>1.0.101</PackageVersion>
+		<PackageVersion>1.0.201</PackageVersion>
 		<PackageId>SpelParser</PackageId>
-		<Version>1.0.101</Version>
+		<Version>1.0.201</Version>
 		<Authors>Saeed Bolhasani</Authors>
 		<PackageDescription>Convert string to expression</PackageDescription>
 		<RepositoryUrl>https://github.com/SaeedBolhasani/SpelParser</RepositoryUrl>