Add opaque pointer in extapi #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuleisui
reviewed
Feb 1, 2024
svf-llvm/lib/LLVMModule.cpp
Outdated
| @@ -240,7 +236,7 @@ void LLVMModuleSet::createSVFFunction(const Function* func) | |||
| SVFUtil::cast<SVFFunctionType>( | |||
| getSVFType(func->getFunctionType())), | |||
| func->isDeclaration(), LLVMUtil::isIntrinsicFun(func), | |||
| func->hasAddressTaken(), func->isVarArg(), new SVFLoopAndDomInfo, LLVMUtil::getFunAnnotations(func)); | |||
| func->hasAddressTaken(), func->isVarArg(), new SVFLoopAndDomInfo, ExtFun2Anno[func]); | |||
There was a problem hiding this comment.
Could you use get method otherwise the map will be touched by every function?
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1355 +/- ##
=======================================
Coverage 66.27% 66.28%
=======================================
Files 227 227
Lines 24641 24656 +15
=======================================
+ Hits 16331 16343 +12
- Misses 8310 8313 +3
|
jumormt
reviewed
Feb 1, 2024
| @@ -77,6 +78,8 @@ class LLVMModuleSet | |||
| FunDefToDeclsMapTy FunDefToDeclsMap; | |||
| /// Record some "sse_" function declarations used in other ext function definition, e.g., svf_ext_foo(), and svf_ext_foo() used in app functions | |||
| FunctionSetType ExtFuncsVec; | |||
| /// Record annotations of function in extapi.bc | |||
| Fun2AnnoMap ExtFun2Anno; | |||
jumormt
reviewed
Feb 1, 2024
| @@ -323,6 +326,15 @@ class LLVMModuleSet | |||
| return it->second; | |||
| } | |||
|
|
|||
| std::vector<std::string> getFunctionAnnotations(const Function* fun) | |||
jumormt
reviewed
Feb 1, 2024
svf-llvm/lib/LLVMModule.cpp
Outdated
| @@ -790,6 +786,57 @@ void LLVMModuleSet::addSVFMain() | |||
| } | |||
| } | |||
|
|
|||
| void LLVMModuleSet::getExtAPIAnnotations(const Module* mod) | |||
jumormt
reviewed
Feb 1, 2024
| @@ -323,6 +326,15 @@ class LLVMModuleSet | |||
| return it->second; | |||
| } | |||
|
|
|||
| std::vector<std::string> getFunctionAnnotations(const Function* fun) | |||
There was a problem hiding this comment.
This function has a redundant vector copy. Consider return a reference to the vector, return an empty field emptyAnnotations if not found. Nevertheless, I think a better solution is to delete this function...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.