fix if offsetVarAndGepTypePair.second is nullptr #1247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1247 +/- ##
==========================================
- Coverage 64.44% 64.44% -0.01%
==========================================
Files 223 223
Lines 23721 23722 +1
==========================================
Hits 15287 15287
- Misses 8434 8435 +1
|
yuleisui
reviewed
Nov 17, 2023
svf/lib/MemoryModel/AccessPath.cpp
Outdated
| @@ -112,6 +112,9 @@ APOffset AccessPath::computeConstantByteOffset() const | |||
| /// i = 0, type: [10 x i8]*, PtrType, op = 0 | |||
| /// i = 1, type: [10 x i8], ArrType, op = 8 | |||
| const SVFType* type = offsetVarAndGepTypePairs[i].second; | |||
| /// if offsetVarAndGepTypePairs[i].second is nullptr, it means | |||
| /// this GepStmt comes from external API, assert | |||
There was a problem hiding this comment.
Add more comments about this from SVFIRBuilder.cpp:getBaseTypeAndFlatternedFields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since it is from External API like memcpy
this GepStmt comes from memcpy, which offsetVarAndGepTypePair[i].second is always nullptr