Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a script and yaml file to setup ds389 in rancher #22

Merged
merged 15 commits into from
Oct 28, 2024
Merged

Added a script and yaml file to setup ds389 in rancher #22

merged 15 commits into from
Oct 28, 2024

Conversation

rmahique
Copy link
Contributor

No description provided.

@devpro devpro self-assigned this Oct 25, 2024
devpro
devpro requested changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@devpro devpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Could you remove the extra empty lines?
    (We should never have more than one empty line)

  2. All the files here are functions, it should never file a sh file we excute
    (scripts/authentication/ds389.sh -> only keep the functions inside)

devpro
devpro requested changes Oct 28, 2024
View reviewed changes
scripts/authentication/ds389.sh Outdated Show resolved Hide resolved
scripts/authentication/389.yml Outdated Show resolved Hide resolved
charts/ds389/templates/namespace.yaml Outdated Show resolved Hide resolved
charts/ds389/templates/service-external.yaml Outdated Show resolved Hide resolved
charts/ds389/templates/service-internal.yaml Outdated Show resolved Hide resolved
charts/ds389/templates/serviceaccount.yaml Outdated Show resolved Hide resolved
charts/ds389/templates/statefulset.yaml Outdated Show resolved Hide resolved
charts/ds389/values.yaml Show resolved Hide resolved
rmahique-github added 2 commits October 28, 2024 12:30
@devpro devpro self-requested a review October 28, 2024 14:45
@devpro devpro merged commit ca8ffa2 into SUSE:develop Oct 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devpro devpro devpro approved these changes

@hierynomus hierynomus Awaiting requested review from hierynomus hierynomus is a code owner

Assignees

@devpro devpro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmahique @devpro