Bugfix for permission management of entities #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazyscientist
changed the title
A small bug allowed authenticated users to perform any actions on entities without permission, when the `reviewable` flag of the schema was unset. On the flip side, it prevented them from creating change requests for entities they had no permissions on. This change fixes the situation: * Any authenticated user is allowed to create change requests * Only authorized users are allowed to apply changes to entities
crazyscientist
force-pushed
the
permission_issue
branch
from
a23d1fd
to
e3f7e49
Compare
crazyscientist
changed the title
der-gabe
reviewed
Nov 24, 2022
der-gabe
reviewed
Nov 24, 2022
der-gabe
reviewed
Nov 24, 2022
Co-authored-by: Gabriel Niebler <[email protected]>
der-gabe
reviewed
Nov 24, 2022
der-gabe
reviewed
Nov 24, 2022
der-gabe
reviewed
Nov 25, 2022
Co-authored-by: Gabriel Niebler <[email protected]>
der-gabe
approved these changes
Nov 25, 2022
|
Thank you 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small bug allowed authenticated users to perform any actions on entities without permission, when the
reviewableflag of the schema was unset. On the flip side, it prevented them from creating change requests for entities they had no permissions on.This change fixes the situation: