Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icorrect encoding of request body in plugins.api.API.login #134

Closed
crazyscientist opened this issue Apr 21, 2023 · 0 comments
Closed

Icorrect encoding of request body in plugins.api.API.login #134

crazyscientist opened this issue Apr 21, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@crazyscientist
Copy link
Collaborator

The body for the login request is constructed like this:

        const body = `username=${username}&password=${password}`;
        const response = await this._fetch({
            url: url,
            method: 'POST',
            body: encodeURI(body),
            headers: {'Content-Type': 'application/x-www-form-urlencoded'}
        });

This is incorrect and prevents users from logging in, if the password starts with a $.

@crazyscientist crazyscientist added the bug Something isn't working label Apr 21, 2023
@crazyscientist crazyscientist self-assigned this Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant