config: added a configurable option for the expiration time of a JWT token #518
Conversation
| @@ -5,6 +5,8 @@ module Portus | |||
| # https://github.com/docker/distribution/blob/master/docs/spec/auth/token.md | |||
| # | |||
| class JwtToken | |||
| DEFAULT_EXPIRATION_TIME = 5.minutes | |||
There was a problem hiding this comment.
This seems to be used only when there's no jwt_expiration_time value configured inside of the config.yml. That should not happen right?
Also this is used when the value is something wrong; in that case I would just let everything crash. That would make the issue evident.
|
LGTM, I not 100% convinced about having the default expiration time defined also inside of the jwt class. |
…token See the isse SUSE#510 Signed-off-by: Miquel Sabaté Solà <[email protected]>
mssola
force-pushed
the
jwt-expiration
branch
from
2f08353
to
6fdeaa5
Compare
|
@flavio agreed. I just changed that. |
config: added a configurable option for the expiration time of a JWT token
|
Did has been tested @mssola ? I do export this ENV var "PORTUS_REGISTRY_JWT_EXIRATION_TIME": "100" but i still get a timeout after 5 minutes. Any clues? I introduced this setting in the rancher catalog questions https://github.com/EugenMayer/docker-rancher-extra-catalogs/blob/master/templates/registry-slim/17/docker-compose.yml#L43 |
|
@EugenMayer works for me if I use: |
|
@mssola why suddenly the _VALUE suffix? most of the variable do not need it? is it special |
|
The |
See the issue #510
Signed-off-by: Miquel Sabaté Solà [email protected]