This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
Review packaging bundling of gems js requirements recommends #1948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What do you mean by this? I see nothing on this regard (as it should) 😕 |
|
@jordimassaguerpla so you meant |
mssola
previously approved these changes
Sep 3, 2018
Vogtinator
reviewed
Sep 3, 2018
packaging/suse/portus.spec.in
Outdated
| @@ -18,6 +18,15 @@ | |||
| %define branch __BRANCH__ | |||
| %define portusdir /srv/Portus | |||
|
|
|||
| %define fix_sheb() ( \ | |||
There was a problem hiding this comment.
Why is that a %define and not just a sh function?
There was a problem hiding this comment.
Why not? Is there a reason not to use a macro?
There was a problem hiding this comment.
It's easier to read (no \ needed) and does not change behaviour depending on context.
MaximilianMeister
previously approved these changes
Sep 3, 2018
|
@MaximilianMeister : good catch. I added a commit defining fix_sheb after |
Let's include the gems as sources instead of build requirements so building this package does not require so many gem packages. Build requiring rubygem packages is a "nightmare" when you try to build portus in different repos: * sometimes the rubygem RPMs are not there and need to be submited * othertimes they are present but have a different version and that creates a conflict Since the new macros in ruby-common are generating the "Provides: bundled(rubygem(foo)) = version" we don't need the BR to explicetely tell which rubygems are in, plus the "provides" is much more explicit. Signed-off-by: Jordi Massaguer Pla <[email protected]>
portusctl is a separate package Signed-off-by: Jordi Massaguer Pla <[email protected]>
This will create automatically the provides for the js libs Signed-off-by: Jordi Massaguer Pla <[email protected]>
we don't recomment mariadb anymore in the RPM since the recommended way is to use an external container review some text in comments Signed-off-by: Jordi Massaguer Pla <[email protected]>
jordimassaguerpla
dismissed stale reviews from MaximilianMeister and mssola
via
89566d7
jordimassaguerpla
force-pushed
the
review_packaging_bundling_of_gems_js_requirements_recommends
branch
from
3d6b245
to
89566d7
Compare
Signed-off-by: Jordi Massaguer Pla <[email protected]>
jordimassaguerpla
force-pushed
the
review_packaging_bundling_of_gems_js_requirements_recommends
branch
from
eaf426d
to
e350e0c
Compare
MaximilianMeister
approved these changes
Sep 4, 2018
mssola
approved these changes
Sep 4, 2018
mssola
deleted the
review_packaging_bundling_of_gems_js_requirements_recommends
branch
|
Thanks @jordimassaguerpla! 👏 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review of how we package (RPM) portus.
Add gems as sources
Autogenerate autoprovides for js files
Remove mariadb requirement
Add kubectl requirement