Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

Added PhantomJS for acceptance tests #193

Merged
merged 3 commits into from
Jul 1, 2015
Merged

Added PhantomJS for acceptance tests #193

merged 3 commits into from
Jul 1, 2015

Conversation

mssola
Copy link
Collaborator

@mssola mssola commented Jul 1, 2015

No description provided.

For now I've added a test when the user is creating a namespace from the team's
page. There are a couple of hacks with this test that need to be fixed.
@mssola
Copy link
Collaborator Author

mssola commented Jul 1, 2015

@flavio I don't know if this PR is enough to close the issue #173 or we should add more tests before. What do you think ?

@flavio
Copy link
Member

flavio commented Jul 1, 2015

I think we can close issue #173 with this one. We can provide more tests later on. It's really important to provide new tests for bug fixes/new features.

Are the tests automatically run on travis?

@mssola
Copy link
Collaborator Author

mssola commented Jul 1, 2015

My plan is to provide acceptance tests on the following days, so the test suite is as complete as possible.

And yes, tests are running automatically.

@flavio
Copy link
Member

flavio commented Jul 1, 2015

👍

flavio added a commit that referenced this pull request Jul 1, 2015
Added PhantomJS for acceptance tests
@flavio flavio merged commit 882d41f into SUSE:master Jul 1, 2015
@mssola mssola deleted the phantom branch July 1, 2015 15:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants