This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
Fixed LDAP crash and improved tests #1834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When guessing the email, we try to fetch the entry by calling `search`. However, we dismissed the fact that this method could return nil (meaning that there was an error on the request, like a SocketError). In this case, from now on it will simply return nil. Fixes SUSE#1832 Signed-off-by: Miquel Sabaté Solà <[email protected]>
There was a lot of unnecessary mocking that prevented us from testing real bugs that were hidden behind all that code. Signed-off-by: Miquel Sabaté Solà <[email protected]>
|
After merging this, the first commit has to be re-adapted into |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has two somewhat related commits: