This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
health: implemented check for LDAP #1828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to implement this, I needed to move things a bit on the LDAP support. So much, that I ended up refactoring quite some pieces that needed it. Fixes SUSE#1810 Signed-off-by: Miquel Sabaté Solà <[email protected]>
|
There are some possible tests still failing. |
mssola
commented
May 23, 2018
| @@ -15,6 +15,8 @@ def self.ready | |||
|
|
|||
| res = ::Registry.get.client.reachable? | |||
| ["registry is#{res ? "" : " not"} reachable", res] | |||
|
|
|||
| # TODO: rescue ::Portus::RequestError instead of simply bailing | |||
There was a problem hiding this comment.
This is to be done on another PR
vitoravelino
approved these changes
May 23, 2018
mssola
added a commit
to mssola/Portus
that referenced
this pull request
Jun 14, 2018
This is a regression that happened after merging SUSE#1828. Fixes SUSE#1850 Signed-off-by: Miquel Sabaté Solà <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to implement this, I needed to move things a bit on the LDAP
support. So much, that I ended up refactoring quite some pieces that
needed it.
Fixes #1810
Signed-off-by: Miquel Sabaté Solà [email protected]