Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

dashboard: unified admin dashboard page with regular page #1786

Merged
merged 1 commit into from
Apr 18, 2018

Conversation

vitoravelino
Copy link
Contributor

@vitoravelino vitoravelino commented Apr 16, 2018

We got rid of the admin dashboard page. We finaly complete the unification
of admin tasks/vision on the regular pages. If the user is an admin,
they will see more things on the page now.

In this case, the dashboard page will show similar components to what the
user used to see on the admin dashboard page. The main difference is that
now we have tabs grouping the types of recent activities.

If the user is a regular one, nothing changes and everything stays the same.

Signed-off-by: Vítor Avelino [email protected]

Regular user

screenshot-20180416143406-1915x431

Admin

screenshot-20180416143430-1915x535

@vitoravelino vitoravelino mentioned this pull request Apr 16, 2018
7 tasks
@Vad1mo
Copy link
Contributor

Vad1mo commented Apr 17, 2018

I liked the dedicated admin area, as everything there was dedicated to the administration.
Audit trails of all users. The widgets.

You shouldn't forget that admins are users too :)
This means that admins in small setups have two roles user & admin. Having them separated reflacts that use case. IMHO Portus is mostly used in this scenarios

@vitoravelino
Copy link
Contributor Author

I liked the dedicated admin area, as everything there was dedicated to the administration.
Audit trails of all users. The widgets.

The widgets and audit trails (recent activities for admin) were not removed. We just unified with the regular dashboard page as you can see on the screenshot.

You shouldn't forget that admins are users too :)
This means that admins in small setups have two roles user & admin. Having them separated reflacts > that use case. IMHO Portus is mostly used in this scenarios

I know and that's why we are trying to improve and create new semantics in the UI. We are trying to be explicit on why the user has access to something and not only listing everything in a single table as it was before. This can always be improved and we'll try to keep working on it.

The reason we are doing this is because the admin pages were not good enough and kinda forgotten this whole time. We also heard complains about them. That's why we decided to do this change.

Nothing prevents us from reverting this in the future if we see that it makes sense to go that way again. But for now we thought that this was a good idea. Hopefully we won't regret this decision. 😅

Thanks for being worried about this!

@Vad1mo
Copy link
Contributor

Vad1mo commented Apr 17, 2018

The point is we have some custom widget that display relevant informations or point to further settings.

In the new setup will the user see the widgets or only the admin?

@vitoravelino
Copy link
Contributor Author

In the new setup will the user see the widgets or only the admin?

Only the admin. I thought I had written that in the commit message but I didn't. My bad. Everything stays the same for the regular user. The changes are only for admins.

@vitoravelino
Copy link
Contributor Author

I'm going to reword the commit later. It's pretty bad.

@mssola you can review this and the other PRs but lemme reword all the commit messages before merging everything, ok?

Copy link
Collaborator

@mssola mssola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that you can remove some routes, no ?

@mssola
Copy link
Collaborator

mssola commented Apr 17, 2018

@mssola you can review this and the other PRs but lemme reword all the commit messages before merging everything, ok?

ugh, I've already merged a couple of them ...

@vitoravelino vitoravelino changed the title dashboard: unified admin vision with regular one dashboard: unified admin dashboard page with regular page Apr 18, 2018
@vitoravelino vitoravelino force-pushed the unify-admin-dashboard branch 3 times, most recently from c0e841a to a824999 Compare April 18, 2018 09:33
We got rid of the admin dashboard page. We finaly complete the unification
of admin tasks/vision on the regular pages. If the user is an admin,
they will see more things on the page now.

In this case, the dashboard page will show similar components to what the
user used to see on the admin dashboard page. The main difference is that
now we have tabs grouping the types of recent activities.

If the user is a regular one, nothing changes and everything stays the same.

Signed-off-by: Vítor Avelino <[email protected]>
@vitoravelino
Copy link
Contributor Author

Good to go.

@mssola mssola merged commit f9324cd into SUSE:master Apr 18, 2018
@vitoravelino vitoravelino deleted the unify-admin-dashboard branch April 20, 2018 13:45
@vitoravelino vitoravelino mentioned this pull request May 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants