This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
namespaces: unified admin page with regular page #1783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitoravelino
force-pushed
the
unify-namespaces
branch
from
7c4a5d2
to
3e56107
Compare
7 tasks
vitoravelino
force-pushed
the
unify-namespaces
branch
from
3e56107
to
a7a586f
Compare
mssola
previously approved these changes
Apr 17, 2018
lib/api/v1/namespaces.rb
Outdated
| detail: "This will expose all accessible namespaces by the user via either team | ||
| membership or visibility. Keep in mind that if the user is an admin, this | ||
| will return all the global, personal and other namespaces created by all | ||
| the users.", |
There was a problem hiding this comment.
Nitpick: remove the "." at the end. When exporting to the documentation we expect all strings to not have a period at the end.
vitoravelino
force-pushed
the
unify-namespaces
branch
from
a7a586f
to
90b52e8
Compare
vitoravelino
changed the title
We got rid of the admin namespaces page and unified the vision of the admin on the regular namespace page. So, if the user is an admin, they will be seeing all of the namespaces and will be able to manage all of them. If the user is a regular one, everything stays the same. API is also affected by this change. One improvement we did was to separate the other namespaces the user had access to without being through membership in a different panel. This will help the user understand better how they have access to those namespaces. Signed-off-by: Vítor Avelino <[email protected]>
vitoravelino
force-pushed
the
unify-namespaces
branch
from
90b52e8
to
6482ed7
Compare
vitoravelino
changed the title
|
Good to go. |
mssola
approved these changes
Apr 18, 2018
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We got rid of the admin namespaces page and unified the vision of the
admin on the regular namespace page. So, if the user is an admin, they
will be seeing all of the namespaces and will be able to manage all of
them. If the user is a regular one, everything stays the same.
API is also affected by this change.
One improvement we did was to separate the other namespaces the user had
access to without being through membership in a different panel. This
will help the user understand better how they have access to those
namespaces.
Signed-off-by: Vítor Avelino [email protected]