This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
webhooks: hide passwords #1111
Merged
webhooks: hide passwords #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tboerger
approved these changes
Oct 26, 2016
jdsn
reviewed
Oct 26, 2016
| @@ -21,6 +21,6 @@ | |||
| th Password | |||
| td | |||
| - if webhook.password.present? | |||
| = webhook.password | |||
| = '*' * webhook.password.length | |||
There was a problem hiding this comment.
Why expose the length of the password? I would use a static or random length.
There was a problem hiding this comment.
And why not using a random number from 0 to 10 for example ?
There was a problem hiding this comment.
I doesn't really matter if it's a random or fixed length. The fixed length string however is really easy to implement.
Signed-off-by: Thomas Hipp <[email protected]>
tboerger
reviewed
Oct 26, 2016
| @@ -21,6 +21,6 @@ | |||
| th Password | |||
| td | |||
| - if webhook.password.present? | |||
| = webhook.password | |||
| = '*' * 11 | |||
There was a problem hiding this comment.
And are you sure we never want to display it? Maybe make it toggleable?
There was a problem hiding this comment.
I would never ever show it. This is asking for trouble imho 😄
mssola
approved these changes
Oct 26, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Thomas Hipp [email protected]