Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport][SES5]Reuse OSD ID in migrations, support replace.osds #1258

Merged
merged 2 commits into from
Aug 23, 2018
Merged

[backport][SES5]Reuse OSD ID in migrations, support replace.osds #1258

merged 2 commits into from
Aug 23, 2018

Conversation

swiftgist
Copy link
Contributor

@swiftgist swiftgist commented Aug 1, 2018 •
edited by jschmid1
Loading

These functions are essentially equivalent and bundled together.

backport of #1216

Signed-off-by: Eric Jackson [email protected]

@swiftgist
Copy link
Contributor Author

Note that SLE12SP3 in VMs does not create the /dev/disk/by-path symlinks. This required adjusting the smoketests to handle the "manual" step.

@swiftgist swiftgist changed the title Reuse OSD ID in migrations, support replace.osds [backport][SES5]Reuse OSD ID in migrations, support replace.osds Aug 1, 2018
@jschmid1
Copy link
Contributor

jschmid1 commented Aug 7, 2018 •
edited
Loading

we need a rebase on that one @swiftgist

@swiftgist swiftgist force-pushed the ses5-wip-migrate branch 2 times, most recently from a91e215 to ec2ca26 Compare August 9, 2018 11:52
@jschmid1
Copy link
Contributor

Replace/Migration backports

@SUSE SUSE deleted a comment from denisok Aug 14, 2018
@SUSE SUSE deleted a comment from denisok Aug 14, 2018
@SUSE SUSE deleted a comment from susebot Aug 14, 2018
@jschmid1
Copy link
Contributor

@swiftgist rebase please

@swiftgist
Reuse OSD ID in migrations, support replace.osds
3c5b2e5 
These functions are essentially equivalent and bundled together.

Signed-off-by: Eric Jackson <[email protected]>
@jschmid1
Copy link
Contributor

@susebot run teuthology

@susebot
Copy link
Collaborator

susebot commented Aug 20, 2018

Commit 3c5b2e5 is NOT OK.
Check tests results in the Jenkins job: http://158.69.90.90:8080/job/deepsea-pr/50/

Use host rather than nodename consistently
bd7eb1d 
Signed-off-by: Joshua Schmid <[email protected]>
(cherry picked from commit 31e9478)
@jschmid1
Copy link
Contributor

@susebot run teuthology

@susebot
Copy link
Collaborator

susebot commented Aug 22, 2018

Commit bd7eb1d is OK.
Check tests results in the Jenkins job: http://158.69.90.90:8080/job/deepsea-pr/54/

@SUSE SUSE deleted a comment from kshtsk Aug 22, 2018
@SUSE SUSE deleted a comment from susebot Aug 22, 2018
@jan--f
Copy link
Contributor

jan--f commented Aug 22, 2018

This is the backport for #1216. See discussion there.

@jschmid1 jschmid1 merged commit e6ee7d3 into SES5 Aug 23, 2018
@smithfarm smithfarm mentioned this pull request Aug 23, 2018
Merged
15 tasks
@jschmid1 jschmid1 added this to the 0.8.6 milestone Aug 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan--f jan--f Awaiting requested review from jan--f

@tserong tserong Awaiting requested review from tserong

@jschmid1 jschmid1 Awaiting requested review from jschmid1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.6
Development

Successfully merging this pull request may close these issues.
4 participants
@swiftgist @jschmid1 @susebot @jan--f