qa: add all possible dummy osd-configurations #1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smithfarm
reviewed
Jul 27, 2018
deepsea.spec.in
Outdated
| %dir /srv/salt/ceph/smoketests/quiescent | ||
| %dir /srv/salt/ceph/smoketests/restart | ||
| %dir /srv/salt/ceph/smoketests/tuned | ||
| %dir /srv/salt/ceph/smoketests/tuned/off |
There was a problem hiding this comment.
drop all the "smoketests" lines above
There was a problem hiding this comment.
they sneaked in during the rebase
jschmid1
force-pushed
the
wip-random-proposals
branch
from
233d0bb to
e4ae092
Compare
smithfarm
reviewed
Jul 27, 2018
deepsea.spec.in
Outdated
| @@ -745,6 +745,8 @@ the README for more information. | |||
|
|
|||
| %files qa | |||
| %{_libexecdir}/deepsea/qa | |||
| %{_libexecdir}/deepsea/qa/osd-config | |||
| %{_libexecdir}/deepsea/qa/osd-config/ovh | |||
There was a problem hiding this comment.
drop these two lines - they're not needed (%{_libexecdir}/deepsea/qa already brings in everything under qa/)
jschmid1
force-pushed
the
wip-random-proposals
branch
2 times, most recently
from
60d9060 to
a44fa8f
Compare
smithfarm
reviewed
Jul 27, 2018
Makefile
Outdated
| @@ -71,10 +71,13 @@ copy-files: | |||
| install -m 600 srv/salt/ceph/salt-api/files/sharedsecret.conf.j2 $(DESTDIR)/etc/salt/master.d/sharedsecret.conf | |||
| # qa | |||
| install -d -m 755 $(DESTDIR)/usr/lib/deepsea/qa/common | |||
| install -d -m 755 $(DESTDIR)/usr/lib/deepsea/qa/osd-config | |||
There was a problem hiding this comment.
this line is also not needed because install -d automatically creates intermediate directories - i.e. qa/osd-config will get created in the next line
qa: add README to clarify Signed-off-by: Joshua Schmid <[email protected]>
jschmid1
force-pushed
the
wip-random-proposals
branch
from
a44fa8f to
e368cda
Compare
smithfarm
approved these changes
Jul 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR $subject in order to feed them to teuthology-ovh ( for now ). That enables us to test all the possible configurations we support with deepsea.
Please find more information on how to run integration tests here