Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DS-989 | Use modals for changemaker card content for all breakpoints #373

Merged
merged 6 commits into from
Dec 11, 2024
Merged

DS-989 | Use modals for changemaker card content for all breakpoints #373

merged 6 commits into from
Dec 11, 2024

Conversation

yvonnetangsu
Copy link
Member

@yvonnetangsu yvonnetangsu commented Dec 10, 2024 •
edited
Loading

READY FOR REVIEW

Summary

  • Use modals for changemaker card content for all breakpoints

Review By (Date)

  • Soon

Criticality

  • 6

Review Tasks

Setup tasks and/or behavior to test

  1. Go to https://deploy-preview-373--giving-campaign.netlify.app/changemakers
  2. Click on a few of the changemaker cards (both horizontal and vertical variants), check that they open up a modal
  3. Check that you can use escape key or click outside the modal to close it
  4. Check that focus trap works
  5. Test on the phone if possible

Associated Issues and/or People

@netlify Netlify
Copy link

netlify bot commented Dec 10, 2024 •
edited
Loading

✅ Deploy Preview for giving-campaign ready!

Name Link
🔨 Latest commit 4be59bc
🔍 Latest deploy log https://app.netlify.com/sites/giving-campaign/deploys/6758d5ee6082170008667650
😎 Deploy Preview https://deploy-preview-373--giving-campaign.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yvonnetangsu yvonnetangsu marked this pull request as ready for review December 10, 2024 23:34
yvonnetangsu
yvonnetangsu commented Dec 10, 2024
View reviewed changes
components/AnnotatedImage/AnnotatedImage.styles.ts
@@ -1,4 +1,4 @@
export const root = 'relative self-start';
export const root = 'relative self-start annotated-image';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For if Forrest wants to track clicks for a specific group of components in Heap.

@sherakama
Copy link
Member

share_6941708397218730939

Looks good on Mobile

sherakama
sherakama approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@sherakama sherakama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

@yvonnetangsu
Copy link
Member Author

Thanks @sherakama ! 😄

@yvonnetangsu yvonnetangsu merged commit 70138b1 into dev Dec 11, 2024
5 checks passed
@yvonnetangsu yvonnetangsu deleted the feature/DS-989/changemaker-modal branch December 11, 2024 21:50
@yvonnetangsu yvonnetangsu mentioned this pull request Dec 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherakama sherakama sherakama approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yvonnetangsu @sherakama