Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS-965: Linting Cache Config & ADR #370

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from
Open

DS-965: Linting Cache Config & ADR #370

wants to merge 11 commits into from

Conversation

sherakama
Copy link
Member

@sherakama sherakama commented Nov 25, 2024

READY FOR REVIEW

Summary

  • Catches up on linting config
  • Adds ADRs for decisions
  • Adds fetch caching
  • Hack patch caching setting
  • Adds config settings
  • Adds metadata to our 404 pages

Review By (Date)

  • Whenever you get time when you are back

Criticality

  • Low, maintenance mostly

Review Tasks

  1. Check out this branch or go to the netlify preview
  2. Click around to see that everything still loads and looks good
  3. Review code and read ADRs
  4. Vist a non-existing page and review the document metadata

Associated Issues and/or People

Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for giving-campaign ready!

Name Link
🔨 Latest commit 3f5009f
🔍 Latest deploy log https://app.netlify.com/sites/giving-campaign/deploys/67475f22c8860c0008bec8fc
😎 Deploy Preview https://deploy-preview-370--giving-campaign.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sherakama sherakama changed the title NoJira: Linting upgrades. DS-965: Linting Cache Config & ADR Nov 26, 2024
@sherakama sherakama marked this pull request as ready for review November 26, 2024 18:00
@sherakama
Copy link
Member Author

@yvonnetangsu welcome back. When you get some time next week please have a look at this.

@yvonnetangsu
Copy link
Member

@yvonnetangsu welcome back. When you get some time next week please have a look at this.

Thanks for the ping @sherakama ! I'll review early next week. Have a great weekend 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants