Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADAPT-000: Netlify No Write Env File #8

Merged
merged 6 commits into from
May 31, 2022
Merged

ADAPT-000: Netlify No Write Env File #8

merged 6 commits into from
May 31, 2022

Conversation

sherakama
Copy link
Member

@sherakama sherakama commented May 30, 2022 •
edited
Loading

READY FOR REVIEW

Summary

  • Skips writing the environment variable file when on the Netlify stack
  • Pulls in the Netlify environment variables set in the UI to contextualize them as well.

Setup tasks and/or behavior to test

  1. Review https://github.com/SU-SWS/adapt-my-account/pull/324 build logs
  2. Test out the preview build for it working as expected
  3. Review code and comment on anything you see

@sherakama sherakama requested a review from mattanglin May 30, 2022 20:37
mattanglin
mattanglin approved these changes May 31, 2022
View reviewed changes
Copy link

@mattanglin mattanglin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 👍🏼

@sherakama sherakama merged commit aaa4eef into dev May 31, 2022
@sherakama sherakama deleted the feature/writes branch May 31, 2022 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattanglin mattanglin mattanglin approved these changes

Assignees
No one assigned
Labels
feature size/l
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sherakama @mattanglin