Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS-450: Upgrade to Node 20 #24

Merged
merged 4 commits into from
Jan 30, 2024
Merged

DS-450: Upgrade to Node 20 #24

merged 4 commits into from
Jan 30, 2024

Conversation

stfurkan
Copy link
Contributor

@stfurkan stfurkan commented Jan 29, 2024

READY FOR REVIEW

Summary

  • Upgrade to Node 20

Review By (Date)

  • January 30, 2024

Criticality

  • 5

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Navigate to the package directory in your local terminal and run npm link
  3. Open another project that we use this package (e.g. saa_alumni) and remove the package npm uninstall netlify-plugin-vault-variables
  4. Link your local package (this branch) to the other project npm link netlify-plugin-vault-variables
  5. Open the netlify-plugin-vault-variables folder in the other project and make sure that we have 20 written in the .nvmrc file
  6. Test vault scripts and make sure it works as expected (i.e. it gets the secrets from the Vault correctly)

Copy link
Member

@sherakama sherakama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

@stfurkan
Copy link
Contributor Author

GTG

Thanks for the review @sherakama :)

@stfurkan stfurkan merged commit d0282e9 into dev Jan 30, 2024
1 check passed
@stfurkan stfurkan deleted the task/DS-450_upgrade-node-20 branch January 30, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants