SWSDEVOPS-000: fix typos #154
Conversation
✅ Deploy Preview for decanter ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@jbickar Since you're already here, may I ask you to fix these 2 lines as well? 🙏🏼 Same file 😄 |
|
I thought I searched for all |
I'm not even sure how the typos got in there the first place. Those links are pretty specific 🤔 Maybe a weird search and replace that affected this page. |
|
|
||
| Screen edge is the minimal amount of space between the outside edge of this centered container and the edge of the browser window. Its margins are set at each breakpoint, up to and not including the largest breakpoint (2XL). The total width of the centered container is not fixed, but rather expands (fluid) as the viewport expands up to 1700px. At which point, the centered container reaches its maximum width of 1500px with screen edge of 100px margin on either side of the container. | ||
|
|
||
| [Screen edge values](https://github.com/SWS/decanter/blob/9442bddc27bd699acdb25c25a1b84b07f905245a/src/plugins/theme/decanter.js#L47) are curated and do not follow a mathematical pattern: | ||
| [Screen edge values](https://github.com/SU-SWS/decanter/blob/9442bddc27bd699acdb25c25a1b84b07f905245a/src/plugins/theme/decanter.js#L47) are curated and do not follow a mathematical pattern: |
There was a problem hiding this comment.
@yvonnetangsu do you want this to point to a branch or a commit?
There was a problem hiding this comment.
@yvonnetangsu do you want this to point to a branch or a commit?
@jbickar Hmm master branch is probably ok now that v7 is default - thanks!
There was a problem hiding this comment.
Thanks for interpreting master = main branch @jbickar. My brain is still in Japan time zone 😆
|
1 sec, more fixups coming. |
| @@ -61,7 +61,7 @@ If you are adding Decanter to an existing project please have a review of the [F | |||
| <div className="children:children:rs-mb-4"> | |||
| 1. **Install Decanter Tailwindcss** | |||
|
|
|||
| The easiest way to add Decanter to your project is to use the npm package manager. | |||
| The easiest way to add Decanter to your project is to use the npm package manager. | |||
There was a problem hiding this comment.
It's 2024 and I'm submitting PRs removing trailing whitespace.
There was a problem hiding this comment.
You can use two or more spaces (commonly referred to as "trailing whitespace") for line breaks in nearly every Markdown application, but it's controversial. It's hard to see trailing whitespace in an editor, and many people accidentally or intentionally put two spaces after every sentence. For this reason, you may want to use something other than trailing whitespace for line breaks. If your Markdown application supports HTML, you can use the
HTML tag.
So you should be replacing the two spaces with a<br /> in this case.
|
I'm gonna merge this in 🚀 |
READY FOR REVIEW
Summary
Review By (Date)
Criticality
Review Tasks