AIS-64 | @jdwjdwjdw | A11y and console fixups #153
Conversation
✅ Deploy Preview for decanter ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -9,7 +9,7 @@ lastUpdatedDate: 2022-04-06T12:00:00.000Z | |||
| <div class="h-full w-full overflow-hidden absolute"> | |||
| <img | |||
| class="h-full w-full object-cover object-center" | |||
| src="https://placekitten.com/1000/750" | |||
There was a problem hiding this comment.
Ah, boo. No more place kitteh.
content/examples/cards.mdx
Outdated
| @@ -200,29 +200,29 @@ lastUpdatedDate: 2023-05-25T12:00:00.000Z | |||
| </Section> | |||
| <Section heading="Library Card" width="full"> | |||
| ```html | |||
| <div class="card block w-full basefont-23 leading-display bg-white text-black border border-solid border-black-10 shadow-md md:max-w-500"> | |||
| <div class="overflow-hidden aspect-[16/9] relative" aria-hidden="true"> | |||
| <div className="card block w-full basefont-23 leading-display bg-white text-black border border-solid border-black-10 shadow-md md:max-w-500"> | |||
There was a problem hiding this comment.
@jdwjdwjdw
It looks like you've changed the example markup from HTML valid markup to React markup. Can you tell me more about why you changed these? This changes the example markup code and they are invalid HTML attributes.
There was a problem hiding this comment.
The stuff inside the html fencing '''html should stay as html and not react.
There was a problem hiding this comment.
Thanks - I got a little overambitious while trying to fix the console errors. Some of the JSX vs HTML did need a little cleanup, so I removed my incorrect changes and kept the ones that needed updating. Should be good for another look now.
|
|
NOT READY FOR REVIEW
Summary
Form field missing a labelA11y issues at https://decanter.stanford.edu/examples/form-elementsReview By (Date)
Criticality
Review Tasks
Setup tasks and/or behavior to test
/examples/form-elements, run the Sitemprove extension, and confirm that theForm field missing a labelA11y issues are no longer being flagged on that page.Associated Issues and/or People