-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Std experimental simd #403
Std experimental simd #403
Conversation
CMakeLists.txt
Outdated
@@ -35,6 +35,7 @@ option(OCTOTIGER_WITH_BOOST_MULTIPRECISION | |||
"Use Boost.Multiprecision Instead of GCC Quad-Precision Math Library" OFF) | |||
option(OCTOTIGER_WITH_QUADMATH "Enable sections using GCC Quad-Precision Math Library" ON) | |||
option(OCTOTIGER_WITH_Vc "" ON) | |||
option(OCTOTIGER_WITH_STD_EXPERIMENTAL_SIMD "" ON) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Kokkos CI Jobs are failing since they're running without std::simd, yet this flag is on by default!
I propose turning it OFF by default (for now) until it becomes less experimental. If you can give me push access to your fork, I can quickly add a new Jenkins Pipeline that additionally builds and tests everything with std::experimental::simd enabled as to prevent this from breaking in the future until we hit the "less experimental" stage (I would simply require your build command and push access).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- My local tests with the std-simd backend enabled passed (as do the Jenkins ones as long as keep Kokkos SIMD as the default for now).
I will add the Jenkins pipeline for this in a separate PR!
name: Adapt experimental::simd to octotiger
about: New simd backend for vectorization
Proposed Changes
OCTOTIGER_WITH_STD_EXPERIMENTAL_SIMD
which enables to usestd::experimental::simd
datatypessimd
data types.