Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Std experimental simd #403

Merged
merged 10 commits into from
Mar 1, 2022

Conversation

srinivasyadav18
Copy link
Contributor


name: Adapt experimental::simd to octotiger
about: New simd backend for vectorization

Proposed Changes

  • Adds new cmake flag OCTOTIGER_WITH_STD_EXPERIMENTAL_SIMD which enables to use std::experimental::simd datatypes
  • Adds new std_simd.hpp for handling simd data types.

@diehlpk diehlpk requested a review from G-071 February 2, 2022 16:53
CMakeLists.txt Outdated
@@ -35,6 +35,7 @@ option(OCTOTIGER_WITH_BOOST_MULTIPRECISION
"Use Boost.Multiprecision Instead of GCC Quad-Precision Math Library" OFF)
option(OCTOTIGER_WITH_QUADMATH "Enable sections using GCC Quad-Precision Math Library" ON)
option(OCTOTIGER_WITH_Vc "" ON)
option(OCTOTIGER_WITH_STD_EXPERIMENTAL_SIMD "" ON)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Kokkos CI Jobs are failing since they're running without std::simd, yet this flag is on by default!

I propose turning it OFF by default (for now) until it becomes less experimental. If you can give me push access to your fork, I can quickly add a new Jenkins Pipeline that additionally builds and tests everything with std::experimental::simd enabled as to prevent this from breaking in the future until we hit the "less experimental" stage (I would simply require your build command and push access).

Copy link
Member

@G-071 G-071 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- My local tests with the std-simd backend enabled passed (as do the Jenkins ones as long as keep Kokkos SIMD as the default for now).

I will add the Jenkins pipeline for this in a separate PR!

@G-071 G-071 enabled auto-merge March 1, 2022 17:49
@G-071 G-071 merged commit b1e2c4f into STEllAR-GROUP:master Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants