Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor changes to add annotations to clarify where the generic async t… #396

Merged
merged 2 commits into from
Jan 14, 2022
Merged

Minor changes to add annotations to clarify where the generic async t… #396

merged 2 commits into from
Jan 14, 2022

Conversation

khuck
Copy link
Contributor

@khuck khuck commented Jan 13, 2022

…ime is being spent
Minor changes to add annotations to clarify where the generic async time is being spent

name: Pullrequest
about: Pullrequest template for octotiger

Fixes #

Proposed Changes

  • adding annotated_functions around future.then() calls to get clarity about difference between summit and piz daint with increased async call time.

Any background context you want to provide?

@khuck khuck requested a review from diehlpk January 13, 2022 21:35
diehlpk
diehlpk approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@diehlpk diehlpk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@diehlpk diehlpk merged commit 1556cb4 into master Jan 14, 2022
@diehlpk diehlpk deleted the adding_async_annotations branch January 14, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diehlpk diehlpk diehlpk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khuck @diehlpk @G-071